Re: [Janitorial] ResetDCA->ResetDCW

[Vincent Béron]

Le lun 12/01/2004 à 02:35, Dmitry Timoshkov a écrit :
> "Vincent Beron" <vberon(a)mecano.gme.usherb.ca> wrote:
> > Changelog:
> > Get rid of a W->A crosscall (ResetDCA->ResetDCW).
> > -HDC WINAPI ResetDCW( HDC hdc, const DEVMODEW *devmode )
> > +HDC WINAPI ResetDCA( HDC hdc, const DEVMODEA *devmode )
> >  {
> > -    return ResetDCA(hdc, (const DEVMODEA*)devmode); /* FIXME */
> > +    DEVMODEW *devmodeW;
> > +    HDC ret;
> > +
> > +    if (devmode) devmodeW = GdiConvertToDevmodeW(devmode);
> > +    else devmodeW = NULL;
> > +
> > +    ret = ResetDCW(hdc, (const DEVMODEW*)devmode);
>
> It would be better to pass a real, newly allocated DEVMODEW* to
> ResetDCW(). That way you shouldn't need to cast type of a pointer.

Actually, devmodeW is already a real DEVMODEW, but I kept devmode in the
ResetDCW call. Stupid me.
I'll resend.

Vincent