6 Aug
2015
6 Aug
'15
5:22 p.m.
2015-08-06 6:58 GMT-06:00 Jacek Caban <jacek(a)codeweavers.com>:
It looks much better, thanks. However, I think we shouldn't call GetHref() and GetTarget() for each event. It means that each element handler needs to check event id instead of moving that to handle_link_events (even in cost of sharing a bit less of code).
Also, please avoid moving eventid_t to mshtml_private.h. You may include htmlevent.h in files that need it.
Good points, thanks. I have revised the commit at https://github.com/alexhenrie/wine/commits/master again to take into account your feedback. -Alex