Re: Beautifying of Unicode mode check in tests

[Dmitry Timoshkov]

"Andriy Palamarchuk" <apa3a(a)yahoo.com> wrote:
> There was a few objections to have ugly conditionals
> for Unicode-specific tests, like
> #ifdef _UNICODE
>  ... unicode-specific tests ...
> #endif
>
> This problem can be resolved by using instead function
> or macro as Unicode indicator. Value of this indicator
> will be defined, basing on presence of _UNICODE macro.
>
> Now we'll have better-looking check, like:
> if (TEST_UNICODE)
> {
>  ... unicode-specific tests ...
> }

IMO unicode tests should be executed unconditionally, they just should
be marked as "expected to fail". If you are going to conditionally run
unicode tests, you eventually will come to a conclusion to conditionally
run too much tests (native APIs, etc.)

-- 
Dmitry.