Re: [PATCH 7/7] winegstreamer: Remove copying support from wg_transform_push_data.

[Zebediah Figura]

On 6/10/22 02:53, Rémi Bernon wrote:
> @@ -323,7 +324,11 @@ HRESULT wg_transform_push_data(struct wg_transform *transform, struct wg_sample
>
> TRACE("transform %p, sample %p.\n", transform, sample);
>
> -    if ((status = __wine_unix_call(unix_handle, unix_wg_transform_push_data, ¶ms)))
> +    wg_sample_queue_begin_append(queue, sample);
> +    status = __wine_unix_call(unix_handle, unix_wg_transform_push_data, ¶ms);
> +    wg_sample_queue_end_append(queue, sample);
> +
> +    if (status)
>           return HRESULT_FROM_NT(status);
>
> return params.result;

I don't hate this, but it makes me nervous, since the intent of the 
helpers was to provide a 1:1 interface to the unix code (modulo types), 
and this breaks that assumption.