Re: [1/2]include: Implement part of nserror.h

[Qian Hong]

Hi Jeff,


 HRESULT WINAPI WMCreateEditor(IWMMetadataEditor **editor)
 {
+    WMMetadataEditor *metadata_editor;
     FIXME("(%p): stub\n", editor);

Looks like now we need to use TRACE instead of FIXME here because
WMCreateEditor is implemented.


-    *editor = NULL;
+    metadata_editor = HeapAlloc(GetProcessHeap(), 0, sizeof(WMMetadataEditor));
+    if (!metadata_editor) return E_OUTOFMEMORY;

-    return E_NOTIMPL;
+    metadata_editor->IWMMetadataEditor_iface.lpVtbl = &VT_Editor;
+    metadata_editor->ref = 0;

Looks like ref count should be 1 instead of 0.

+    *editor = &metadata_editor->IWMMetadataEditor_iface;
+
+    return S_OK;
 }

+
Looks like this empty line is unwanted.


-- 
Regards,
Qian Hong

-
http://www.winehq.org