Re: quartz: Check allocation failure and clear memory in DSound Renderer

[Detlef Riekenberg]

On Fr, 2007-03-09 at 03:02 -0800, Chris Robinson wrote:
> +    ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl));

Since you clear the whole struct, ...
> pDSoundRender->lpVtbl = &DSoundRender_Vtbl;
>      pDSoundRender->IBasicAudio_vtbl = &IBasicAudio_Vtbl;
> @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter,
> LPVOID * ppv)
>      pDSoundRender->pClock = NULL;
>      pDSoundRender->init = FALSE;
>      pDSoundRender->started = FALSE;

... there is no need to clear it again.


-- 
 
By by ... Detlef