Re: [PATCH v3 2/4] d3dx10: Implement D3DX10CreateTextureFromMemory initially.

[Matteo Bruni]

On Thu, Jul 1, 2021 at 8:08 AM Ziqing Hui <zhui(a)codeweavers.com> wrote:
> Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com>
> ---
>  dlls/d3dx10_43/d3dx10_43_main.c |  11 --
>  dlls/d3dx10_43/tests/d3dx10.c   |   8 +-
>  dlls/d3dx10_43/texture.c        | 229 ++++++++++++++++++++++++++++++++
>  3 files changed, 232 insertions(+), 16 deletions(-)

> +    stride = (width * get_bpp_from_format(img_info.Format) + 7) / 8;

Nitpick, 8 could be replaced by CHAR_BIT (likewise 7 could be CHAR_BIT - 1).