Re: [PATCH] [Server]: correctly set the DR0..7 registers on Linux for x86_64 architecture

[Dmitry Timoshkov]

Eric Pouech <eric.pouech(a)orange.fr> wrote:
> +    case CPU_x86_64:
> +        context->debug.x86_64_regs.dr0 = data[0];
> +        context->debug.x86_64_regs.dr1 = data[1];
> +        context->debug.x86_64_regs.dr2 = data[2];
> +        context->debug.x86_64_regs.dr3 = data[3];
> +        context->debug.x86_64_regs.dr6 = data[6];
> +        context->debug.x86_64_regs.dr7 = data[7];
> +    default:
> +        set_error( STATUS_INVALID_PARAMETER );
> +        goto done;
> +    }

You forgot 'break'.
> +    case CPU_x86_64:
> +        if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(0), context->debug.x86_64_regs.dr0 ) == -1) goto error;
> +        if (thread->context) thread->context->debug.x86_64_regs.dr0 = context->debug.x86_64_regs.dr0;
> +        if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(1), context->debug.x86_64_regs.dr1 ) == -1) goto error;
> +        if (thread->context) thread->context->debug.x86_64_regs.dr1 = context->debug.x86_64_regs.dr1;
> +        if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(2), context->debug.x86_64_regs.dr2 ) == -1) goto error;
> +        if (thread->context) thread->context->debug.x86_64_regs.dr2 = context->debug.x86_64_regs.dr2;
> +        if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(3), context->debug.x86_64_regs.dr3 ) == -1) goto error;
> +        if (thread->context) thread->context->debug.x86_64_regs.dr3 = context->debug.x86_64_regs.dr3;
> +        if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(6), context->debug.x86_64_regs.dr6 ) == -1) goto error;
> +        if (thread->context) thread->context->debug.x86_64_regs.dr6 = context->debug.x86_64_regs.dr6;
> +        if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(7), context->debug.x86_64_regs.dr7 ) == -1) goto error;
> +        if (thread->context) thread->context->debug.x86_64_regs.dr7 = context->debug.x86_64_regs.dr7;
> +    default:
> +        set_error( STATUS_INVALID_PARAMETER );
> +    }

Same here.

-- 
Dmitry.