Re: [PATCH] urlmon/uri: Implement IsEqual for external implementations.

[Jacek Caban]

Hi Nikolay,

On 09/17/2018 06:00 AM, Nikolay Sivov wrote:
> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
> ---
>  dlls/opcservices/tests/opcservices.c |  3 +--
>  dlls/urlmon/uri.c                    | 18 ++++++++++++++++--
>  2 files changed, 17 insertions(+), 4 deletions(-)

It would be interesting to have some urlmon tests for that. While what
you do seems reasonable, a test in opcservices is not convincing. For
all I know, native opcservices may call urlmon in a different way (or
not at all). Please add a custom IUri implementation inside urlmon tests
pass that to IsEqual.


Jacek