Re: [PATCH v4 2/8] reg.exe: Add path_get_key() to remove boilerplate

13 Oct 2014

      -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-10-13 16:51, schrieb Jonathan Vollebregt:
...
Trailing spaces are valid key names (At least in wine, I imagine
in native too)
Sorry, I meant (and the example used it that way) leading spaces. That
would affect the way you check for remote keys. Obviously trailing
spaces need tests too, but if advapi32 handles them you don't need
extra handling in the implementation.
...
The closest thing I have to a native windows system is testbot and
I doubt you'd want me clogging it up just to find out what the
proper reg inputs are.
If anyone can write tests for the rest, that would be great!
That's exactly what the testbot is there for. No excuses ;-) . But
you'll be happier with your own windows machine (or VM) because it has
a way faster response time than the testbot.
There's no point in changing the argument handling if we don't know
that the changes are actually correct.

Re: [PATCH v4 2/8] reg.exe: Add path_get_key() to remove boilerplate

Stefan Dösinger