Re: [PATCH 1/5] include: Fix undefined char16_t with -DWINE_UNICODE_CHAR16.

[Jacek Caban]

Hi Kevin,

On 17.07.2020 03:09, Puetz Kevin A wrote:
> In c++11 char16_t is a built-in fundamental type,
> but in c11 it is a typedef from <uchar.h>

I was assuming that WINE_UNICODE_CHAR16 is mostly for C++, it doesn't 
seem very useful in C. Is there a reason it's needed?

If the concern is that things break when it's defined, maybe we could 
change checks to make it no-op in C:

#if defined(WINE_UNICODE_CHAR16) && defined(__cplusplus)

We'd then typedef WCHAR to unsigned short, like we usually do. uchar.h 
uses unsigned short as well, so the result should be the same without 
introducing an additional includes.


Thanks,

Jacek