Re: [PATCH v10 2/5] wmp: Add media completion notifications

[Anton Romanov]

On Tue, Apr 10, 2018 at 8:37 AM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> On 04/06/2018 09:22 PM, Anton Romanov wrote:
> > static void test_wmp(void)
> >  {
> >      DWORD res = 0;
> > @@ -339,9 +425,12 @@ START_TEST(media)
> >
> > main_thread_id = GetCurrentThreadId();
> >      playing_event = CreateEventW(NULL, FALSE, FALSE, NULL);
> > +    completed_event = CreateEventW(NULL, FALSE, FALSE, NULL);
> >      test_wmp();
> > +    test_completion_event();
>
> Is there any reason not to add those tests to existing test_wmp()? It
> seems that it already does play() right before the end of tests.
> I use a different file to test completion. The one used in main suite
> is 60 second long as I meant to test calls while file is playing.
> The one used in completion test is 1s long.