Re: [PATCH] shell32: add stub for Shell_NotifyIconGetRect

[Nikolay Sivov]

> +/*************************************************************************
> + * Shell_NotifyIconGetRect		[SHELL32.@]
> + */
> +HRESULT WINAPI Shell_NotifyIconGetRect(const NOTIFYICONIDENTIFIER* identifier, RECT* icon_location)
> +{
> +    FIXME("stub (%p) (%p)\n", identifier, icon_location);
> +    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> +    return E_NOTIMPL;
> +}
> Usually it's either HRESULT or last error, not both.
> +#if NTDDI_VERSION >= 0x06010000
> +HRESULT Shell_NotifyIconGetRect(const NOTIFYICONIDENTIFIER* identifier, RECT* iconLocation);
> +#endif
> Prototype is wrong. Also, why do you need version check?