Re: attrib.exe[2/4] add usage function

[Jeff Zaroyko]

On Sun, Aug 16, 2009 at 2:12 PM, EA Durbin<ead1234(a)hotmail.com> wrote:
> ________________________________
> Windows Live™: Keep your life in sync. Check it out.

Hi EA

I posted these comments on bugzilla before I also saw that you
submitted the patchset:

in patch 2, you should just use one call to printf or just puts, one call per
line is not necessary, just do as such:

printf("foo\n"
        "bar\n"
        "baz\n");

Why does the usage function return 1?  I see that you propagate it as
the return value on
incorrect usage, attrib.exe still returns 0 on Windows if you give an invalid
option:

C:\Users\jeffz>attrib +J foo
Invalid switch - +J

C:\Users\jeffz>echo %ERRORLEVEL%
0

-Jeff