Re: [2/2] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load().

[Nikolay Sivov]

On 5/3/2011 08:07, Adam Martinson wrote:
> Fixes bug 14864.
> ---
>  dlls/msxml3/domdoc.c |  255 
> ++++++++++++++++++++++++++------------------------
>  1 files changed, 134 insertions(+), 121 deletions(-)
>
> +    case VT_ARRAY|VT_UI1:
> +        {
> +            SAFEARRAY* psa;
> +            BSTR bstr;
> +            psa = V_ARRAY(&source);
> +            bstr = bstr_from_xmlChar(psa->pvData);
> +            hr = domdoc_loadXML(iface, bstr, isSuccessful);
> +            SysFreeString(bstr);
> +            return hr;
> +        }
> +        break;

Is it really supposed to be utf8 array? Or this will work cause one-byte 
chars match utf8?

Also I don't like this method dependency, I think the proper way is to 
call IXMLDOMDocument3_loadXML(iface...) here.
Or another way to avoid call through vtable - introduce something called 
domdoc_load_xml(This...) and use it in both places,
but I think it's not worth it.