Re: [PATCH v8 4/9] kernel32/tests: Add GetSystemFirmwareTable tests

[Alex Henrie]

On Wed, Jul 11, 2018 at 10:23 AM Huw Davies <huw(a)codeweavers.com> wrote:
> On Wed, Jun 20, 2018 at 11:18:47PM -0600, Alex Henrie wrote:
> > +    {
> > +        len = GetSystemFirmwareTable(RSMB, i, smbios_table, expected_len);
> > +        ok(len == expected_len, "Table %u: Expected length %u, got %u\n", i, expected_len, len);
>
> I'd hoped for a memcmp between smbios_table and sfti->TableBuffer here.

I didn't want to memcmp the entire buffer because some SMBIOS values
change over time. However, we can reliably memcmp the SMBIOS prologue
that Windows adds, which is the first 6 bytes. My next revision will
have this change.

Thanks for the feedback!

-Alex