Re: Fabian Maurer : comctl32/taskdialog: Move TaskDialogIndirect and its tests into own source files.

[Fabian Maurer]

Is there a reason you changed that copyright notice from
"Copyright 2017 Fabian Maurer for the Wine project"
to
"Copyright 2017 Fabian Maurer"
only in one place?
If you wanted that "for the Wine project" part removed, I don't mind that, but 
I figured you'd do it at both places then.

Regards,
Fabian Maurer

Fabian Maurer : comctl32/taskdialog: Move TaskDialogIndirect and its tests into own source files.

[Nikolay Sivov]

On 18.03.2017 1:26, Fabian Maurer wrote:
> Is there a reason you changed that copyright notice from
> "Copyright 2017 Fabian Maurer for the Wine project"
> to
> "Copyright 2017 Fabian Maurer"
> only in one place?
> If you wanted that "for the Wine project" part removed, I don't mind that, but 
> I figured you'd do it at both places then.

I didn't remove it, see patch I sent.
> Regards,
> Fabian Maurer

Fabian Maurer : comctl32/taskdialog: Move TaskDialogIndirect and its tests into own source files.

[Fabian Maurer]

> > Is there a reason you changed that copyright notice from
> > "Copyright 2017 Fabian Maurer for the Wine project"
> > to
> > "Copyright 2017 Fabian Maurer"
> > only in one place?
> > If you wanted that "for the Wine project" part removed, I don't mind that,
> > but I figured you'd do it at both places then.
>
> I didn't remove it, see patch I sent.

@Nikolay Sivov
Oh sorry, I just looked at the wine-cvs message and didn't expect the patch to 
be changed before committing.

@Alexandre Julliard
Is there a reason for changing the copyright notice?

Regards,
Fabian Maurer

Fabian Maurer : comctl32/taskdialog: Move TaskDialogIndirect and its tests into own source files.

[Alexandre Julliard]

Fabian Maurer <dark.shadow4(a)web.de> writes:
> > > Is there a reason you changed that copyright notice from
> > > "Copyright 2017 Fabian Maurer for the Wine project"
> > > to
> > > "Copyright 2017 Fabian Maurer"
> > > only in one place?
> > > If you wanted that "for the Wine project" part removed, I don't mind that,
> > > but I figured you'd do it at both places then.
> >
> > I didn't remove it, see patch I sent.
>
> @Nikolay Sivov
> Oh sorry, I just looked at the wine-cvs message and didn't expect the patch to 
> be changed before committing.
>
> @Alexandre Julliard
> Is there a reason for changing the copyright notice?

"for the Wine project" is not necessary. It should be removed in the
test too, I missed that one.

-- 
Alexandre Julliard
julliard(a)winehq.org

Fabian Maurer : comctl32/taskdialog: Move TaskDialogIndirect and its tests into own source files.

[Nikolay Sivov]

On 18.03.2017 5:57, Fabian Maurer wrote:
> > > Is there a reason you changed that copyright notice from
> > > "Copyright 2017 Fabian Maurer for the Wine project"
> > > to
> > > "Copyright 2017 Fabian Maurer"
> > > only in one place?
> > > If you wanted that "for the Wine project" part removed, I don't mind that,
> > > but I figured you'd do it at both places then.
> >
> > I didn't remove it, see patch I sent.
>
> @Nikolay Sivov
> Oh sorry, I just looked at the wine-cvs message and didn't expect the patch to 
> be changed before committing.

I'm working on improving the rest of series, should be ready soon.