Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

[Paul Vriens]

On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote:
> ---
>   dlls/ws2_32/tests/sock.c |   46 +++++++++++++++++++++++++++++++++++++---------
>   1 files changed, 37 insertions(+), 9 deletions(-)
>
> ------------------------------------------------------------------------

Hi Mike,

This one has introduced a test failure on Win98 and WinMe.

Could you have a look? Let me know if you want me to run extra tests on 
these boxes.

-- 
Cheers,

Paul.

[PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

[Mike Kaplinskiy]

On Wed, Sep 30, 2009 at 2:35 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote:
> > ---
> >  dlls/ws2_32/tests/sock.c |   46
> > +++++++++++++++++++++++++++++++++++++---------
> >  1 files changed, 37 insertions(+), 9 deletions(-)
> >
> > ------------------------------------------------------------------------
>
> Hi Mike,
>
> This one has introduced a test failure on Win98 and WinMe.
>
> Could you have a look? Let me know if you want me to run extra tests on
> these boxes.
>
> --
> Cheers,
>
> Paul.

Paul,

I'm tempted to say that's a bug in 98/ME - seems like an accepted
socket is holding a reference to the listener that accepted it. Could
you test the patch? It just closes the accepted sockets before doing
the next test.

I think regardless though, we should mark it as broken on 95/ME. I'll
send a patch in the next few days.

Mike.

[PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

[Paul Vriens]

On 09/30/2009 09:41 AM, Mike Kaplinskiy wrote:
> On Wed, Sep 30, 2009 at 2:35 AM, Paul Vriens<paul.vriens.wine(a)gmail.com>  wrote:
> > On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote:
> > > ---
> > >   dlls/ws2_32/tests/sock.c |   46
> > > +++++++++++++++++++++++++++++++++++++---------
> > >   1 files changed, 37 insertions(+), 9 deletions(-)
> > >
> > > ------------------------------------------------------------------------
> >
> > Hi Mike,
> >
> > This one has introduced a test failure on Win98 and WinMe.
> >
> > Could you have a look? Let me know if you want me to run extra tests on
> > these boxes.
> >
> > --
> > Cheers,
> >
> > Paul.
>
> Paul,
>
> I'm tempted to say that's a bug in 98/ME - seems like an accepted
> socket is holding a reference to the listener that accepted it. Could
> you test the patch? It just closes the accepted sockets before doing
> the next test.

No difference, still fails at the same place.
> I think regardless though, we should mark it as broken on 95/ME. I'll
> send a patch in the next few days.

Thanks,

Paul.