[PATCH] winmm: Add a WARNing when winejoystick.drv is missing.

[Serge Gautherie]

Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr>
---
If winejoystick.drv is expected to be present by default,
then this should be promoted to an ERRor...
---
 dlls/winmm/joystick.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/winmm/joystick.c b/dlls/winmm/joystick.c
index 5a12b36..92a7ce9 100644
--- a/dlls/winmm/joystick.c
+++ b/dlls/winmm/joystick.c
@@ -79,6 +79,8 @@ static	BOOL JOY_LoadDriver(DWORD dwJoyID)
 
     if (!JOY_Sticks[dwJoyID].hDriver)
     {
+        WARN("OpenDriverA(\"winejoystick.drv\") failed\n");
+
         /* The default driver is missing, don't attempt to load it again */
         winejoystick_missing = TRUE;
     }
-- 
2.10.0.windows.1

[Andrew Eikum]

On Fri, Nov 16, 2018 at 12:52:52AM +0100, Serge Gautherie wrote:
> diff --git a/dlls/winmm/joystick.c b/dlls/winmm/joystick.c
> index 5a12b36..92a7ce9 100644
> --- a/dlls/winmm/joystick.c
> +++ b/dlls/winmm/joystick.c
> @@ -79,6 +79,8 @@ static	BOOL JOY_LoadDriver(DWORD dwJoyID)
>
> if (!JOY_Sticks[dwJoyID].hDriver)
>      {
> +        WARN("OpenDriverA(\"winejoystick.drv\") failed\n");
> +
>          /* The default driver is missing, don't attempt to load it again */
>          winejoystick_missing = TRUE;
>      }

Presumably the reactos people don't build winejoystick.drv on purpose.
Why do we want to add a WARN for them?

Baruch, you worked here recently, any thoughts?

Andrew

[Serge Gautherie]

On 19/11/2018 14:50, Andrew Eikum wrote:
> Presumably the reactos people don't build winejoystick.drv on purpose.

I'm one of them... ;-)
Correct: ReactOS has no joystick driver (yet).
> Why do we want to add a WARN for them?

As an explicit reminder. If I remember correctly, ReactOS even discards 
WARNs by default.
If ReactOS doesn't like it, they can tweak/disable it on their side.

--

[Andrew Eikum]

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com>

On Fri, Nov 16, 2018 at 12:52:52AM +0100, Serge Gautherie wrote:
> Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr>
> ---
> If winejoystick.drv is expected to be present by default,
> then this should be promoted to an ERRor...
> ---
>  dlls/winmm/joystick.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/dlls/winmm/joystick.c b/dlls/winmm/joystick.c
> index 5a12b36..92a7ce9 100644
> --- a/dlls/winmm/joystick.c
> +++ b/dlls/winmm/joystick.c
> @@ -79,6 +79,8 @@ static	BOOL JOY_LoadDriver(DWORD dwJoyID)
>
> if (!JOY_Sticks[dwJoyID].hDriver)
>      {
> +        WARN("OpenDriverA(\"winejoystick.drv\") failed\n");
> +
>          /* The default driver is missing, don't attempt to load it again */
>          winejoystick_missing = TRUE;
>      }
> -- 
> 2.10.0.windows.1