Re: [PATCH] qedit: use skip in MediaDet test

[Lei Zhang]

On Thu, Feb 21, 2008 at 5:15 PM, Lei Zhang <thestig(a)google.com> wrote:
> Hi,
>
> Dank pointed out the qedit test crashes with an old .wine directory.
>  Adding a skip().

Any reason why this wasn't committed?

[PATCH] qedit: use skip in MediaDet test

[Alexandre Julliard]

"Lei Zhang" <thestig(a)google.com> writes:
> On Thu, Feb 21, 2008 at 5:15 PM, Lei Zhang <thestig(a)google.com> wrote:
> > Hi,
> >
> > Dank pointed out the qedit test crashes with an old .wine directory.
> >  Adding a skip().
>
> Any reason why this wasn't committed?

A skip() is for things that cannot be tested because some feature can
legitimately be missing on Windows. Having a not up-to-date Wine
registry is not a legitimate setup, there's no reason for the test to
try to cope with that.

-- 
Alexandre Julliard
julliard(a)winehq.org