Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.
"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote:
We have to call PostMessage to send WM_IME_NOTIFY message. To send WM_IME_CONTROL, we use SendMessage, but WM_IME_NOTIFY is not...
changelog: Use the PostMessageW for WM_IME_NOTIFY message.
Aric just changed the code to use SendMessage for WM_IME_NOTIFY message. Sounds like it's time to write some message tests or look at the existing ones (which confirm that WM_IME_SETCONTEXT and WM_IME_NOTIFY are sent, not posted). -- Dmitry.
Hi, I think we have to use "PostMessage" to send WM_IME_SETCONTEXT too. Using the "SendMessage" change the real WM_IME_* message ordering. It caused misunderstooding when I tested for my IME message test program. But, at currently wine IME implementation, it is a minor problem. I'll consider this problem when i test on my local git branch. :) Thanks your reply. Dmitry Timoshkov wrote:
"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote:
We have to call PostMessage to send WM_IME_NOTIFY message. To send WM_IME_CONTROL, we use SendMessage, but WM_IME_NOTIFY is not...
changelog: Use the PostMessageW for WM_IME_NOTIFY message.
Aric just changed the code to use SendMessage for WM_IME_NOTIFY message. Sounds like it's time to write some message tests or look at the existing ones (which confirm that WM_IME_SETCONTEXT and WM_IME_NOTIFY are sent, not posted).
"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote:
I think we have to use "PostMessage" to send WM_IME_SETCONTEXT too. Using the "SendMessage" change the real WM_IME_* message ordering. It caused misunderstooding when I tested for my IME message test program. But, at currently wine IME implementation, it is a minor problem. I'll consider this problem when i test on my local git branch. :)
I'd suggest in order to avoid misunderstanding and speculation pay a bit of attention to the results of existing message tests, and if necessary exercise being implemented behaviour in new tests. -- Dmitry.
Thanks you. Dmitry Timoshkov wrote:
"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote:
I think we have to use "PostMessage" to send WM_IME_SETCONTEXT too. Using the "SendMessage" change the real WM_IME_* message ordering. It caused misunderstooding when I tested for my IME message test program. But, at currently wine IME implementation, it is a minor problem. I'll consider this problem when i test on my local git branch. :)
I'd suggest in order to avoid misunderstanding and speculation pay a bit of attention to the results of existing message tests, and if necessary exercise being implemented behaviour in new tests.
participants (2)
-
Byeong-Sik Jeon -
Dmitry Timoshkov