Re: [try2 1/1] msi/tests: automation: Fix pointer check before calling lstrcpyW.
28 Nov
2007
28 Nov
'07
12:50 p.m.
Misha Koshelev <mk144210(a)bcm.edu> writes:
The previous patch was last week I think. This fixes a Valgrind error in the test. This is correct as vtResult is just hte _expected_ return type, and this way we check the actual return type (new this version) and then the validity of the pointer (same as old patch) before calling lstrcpyW so we don't pass NULL to lstrcpyW.
It seems to me what you really want to do is check that the call succeeded, instead of relying on the variant being cleared on error. -- Alexandre Julliard julliard(a)winehq.org
6597
Age (days ago)
6597
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alexandre Julliard