[PATCH] wininet: Fix off by 1 error when parsing time.
This patch makes HTTP_ParseRfc1123Date() work for dates without space before "GMT". Since this is an internal helper there's no way to add a test case for this. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/wininet/http.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index fc412849eb..cf156a9eb5 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -4375,8 +4375,7 @@ static BOOL HTTP_ParseTime(SYSTEMTIME *st, LPCWSTR *str) ERR("unexpected second in time format %s\n", debugstr_w(ptr)); return FALSE; } - ptr = nextPtr + 1; - *str = ptr; + *str = nextPtr; st->wSecond = (WORD)num; return TRUE; } -- 2.20.1
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=57801 Your paranoid android. === debian10 (32 bit report) === wininet: ftp.c:81: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110 ftp.c:112: Test failed: InternetConnect failed : 12110 ftp.c:113: Test failed: ERROR_SUCCESS, got 12110 ftp.c:122: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110 ftp.c:744: Test failed: 9: expected FtpCommandA to succeed ftp.c:745: Test failed: 9: expected error 0, got 12003 ftp.c:744: Test failed: 10: expected FtpCommandA to succeed ftp.c:745: Test failed: 10: expected error 0, got 12003 ftp.c:744: Test failed: 12: expected FtpCommandA to succeed ftp.c:745: Test failed: 12: expected error 0, got 12003 ftp.c:761: Test failed: Expected FtpFindFirstFileA to pass ftp.c:766: Test succeeded inside todo block: Expected FtpFindFirstFileA to fail ftp.c:767: Test succeeded inside todo block: Expected ERROR_FTP_TRANSFER_IN_PROGRESS, got 12110 ftp.c:776: Test failed: Expected FtpFindFirstFileA to pass ftp.c:782: Test failed: Expected FtpFindFirstFileA to pass ftp.c:794: Test failed: Expected FtpSetCurrentDirectory to succeed ftp.c:798: Test failed: Expected FtpFindFirstFileA to pass ftp.c:803: Test failed: Expected FtpFindFirstFileA to pass ftp.c:807: Test failed: Expected FtpSetCurrentDirectory to succeed ftp.c:812: Test failed: Expected FtpOpenFileA to succeed ftp.c:813: Test failed: Expected ERROR_SUCCESS, got 12110 === debian10 (32 bit Chinese:China report) === wininet: ftp.c:81: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110 ftp.c:112: Test failed: InternetConnect failed : 12110 ftp.c:113: Test failed: ERROR_SUCCESS, got 12110 ftp.c:122: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110 ftp.c:744: Test failed: 9: expected FtpCommandA to succeed ftp.c:745: Test failed: 9: expected error 0, got 12003 ftp.c:744: Test failed: 10: expected FtpCommandA to succeed ftp.c:745: Test failed: 10: expected error 0, got 12003 ftp.c:744: Test failed: 12: expected FtpCommandA to succeed ftp.c:745: Test failed: 12: expected error 0, got 12003 ftp.c:761: Test failed: Expected FtpFindFirstFileA to pass ftp.c:766: Test succeeded inside todo block: Expected FtpFindFirstFileA to fail ftp.c:767: Test succeeded inside todo block: Expected ERROR_FTP_TRANSFER_IN_PROGRESS, got 12110 ftp.c:776: Test failed: Expected FtpFindFirstFileA to pass ftp.c:782: Test failed: Expected FtpFindFirstFileA to pass ftp.c:794: Test failed: Expected FtpSetCurrentDirectory to succeed ftp.c:798: Test failed: Expected FtpFindFirstFileA to pass ftp.c:803: Test failed: Expected FtpFindFirstFileA to pass ftp.c:807: Test failed: Expected FtpSetCurrentDirectory to succeed ftp.c:812: Test failed: Expected FtpOpenFileA to succeed ftp.c:813: Test failed: Expected ERROR_SUCCESS, got 12110 === debian10 (32 bit WoW report) === wininet: ftp.c:81: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110 ftp.c:112: Test failed: InternetConnect failed : 12110 ftp.c:113: Test failed: ERROR_SUCCESS, got 12110 ftp.c:122: Test failed: Expected ERROR_INTERNET_LOGIN_FAILURE, got 12110 ftp.c:744: Test failed: 9: expected FtpCommandA to succeed ftp.c:745: Test failed: 9: expected error 0, got 12003 ftp.c:744: Test failed: 10: expected FtpCommandA to succeed ftp.c:745: Test failed: 10: expected error 0, got 12003 ftp.c:744: Test failed: 12: expected FtpCommandA to succeed ftp.c:745: Test failed: 12: expected error 0, got 12003 ftp.c:761: Test failed: Expected FtpFindFirstFileA to pass ftp.c:766: Test succeeded inside todo block: Expected FtpFindFirstFileA to fail ftp.c:767: Test succeeded inside todo block: Expected ERROR_FTP_TRANSFER_IN_PROGRESS, got 12110 ftp.c:776: Test failed: Expected FtpFindFirstFileA to pass ftp.c:782: Test failed: Expected FtpFindFirstFileA to pass ftp.c:794: Test failed: Expected FtpSetCurrentDirectory to succeed ftp.c:798: Test failed: Expected FtpFindFirstFileA to pass ftp.c:803: Test failed: Expected FtpFindFirstFileA to pass ftp.c:807: Test failed: Expected FtpSetCurrentDirectory to succeed ftp.c:812: Test failed: Expected FtpOpenFileA to succeed ftp.c:813: Test failed: Expected ERROR_SUCCESS, got 12110 === debian10 (64 bit WoW report) === wininet: ftp.c:744: Test failed: 9: expected FtpCommandA to succeed ftp.c:745: Test failed: 9: expected error 0, got 12003 ftp.c:744: Test failed: 10: expected FtpCommandA to succeed ftp.c:745: Test failed: 10: expected error 0, got 12003 ftp.c:744: Test failed: 12: expected FtpCommandA to succeed ftp.c:745: Test failed: 12: expected error 0, got 12003 ftp.c:761: Test failed: Expected FtpFindFirstFileA to pass ftp.c:766: Test succeeded inside todo block: Expected FtpFindFirstFileA to fail ftp.c:767: Test succeeded inside todo block: Expected ERROR_FTP_TRANSFER_IN_PROGRESS, got 12110 ftp.c:776: Test failed: Expected FtpFindFirstFileA to pass ftp.c:782: Test failed: Expected FtpFindFirstFileA to pass ftp.c:794: Test failed: Expected FtpSetCurrentDirectory to succeed ftp.c:798: Test failed: Expected FtpFindFirstFileA to pass ftp.c:803: Test failed: Expected FtpFindFirstFileA to pass ftp.c:807: Test failed: Expected FtpSetCurrentDirectory to succeed ftp.c:812: Test failed: Expected FtpOpenFileA to succeed ftp.c:813: Test failed: Expected ERROR_SUCCESS, got 12110
participants (2)
-
Dmitry Timoshkov -
Marvin