Re: [2/6] uuid: add transact.h and txdtc.h

[Frédéric Delanoy]

On Wed, May 1, 2013 at 11:19 PM, Daniel Jeliński <djelinski1(a)gmail.com>wrote:
> #include "msdasc.h"
>
> +#include "transact.h"
> +#include "txdtc.h"

A patch only adding new headers for inclusion is likely not acceptable.
You should merge it with another patch making use of it.

Frédéric

[2/6] uuid: add transact.h and txdtc.h

[Daniel Jeliński]

There were already similar changes to uuid.c in the past, for example these:
http://source.winehq.org/git/wine.git/commitdiff/eda7615d699eb01a73e7bf7e30b...
http://source.winehq.org/git/wine.git/commitdiff/97f4b22543c44216f5286eb1cd4...
but you have a good point. I'm adding interfaces in the same series, might
as well merge the patches.
Thanks for the review,
Daniel


2013/5/2 Frédéric Delanoy <frederic.delanoy(a)gmail.com>
> On Wed, May 1, 2013 at 11:19 PM, Daniel Jeliński <djelinski1(a)gmail.com>wrote:
> > #include "msdasc.h"
> >
> > +#include "transact.h"
> > +#include "txdtc.h"
>
> A patch only adding new headers for inclusion is likely not acceptable.
> You should merge it with another patch making use of it.
>
> Frédéric