Re: [PATCHv5 3/3] d3d9/tests: Add tests for different YUV texture layouts
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Looks good, thanks! Wrt the testbot failures: It looks like CheckDeviceFormatConversion is in fact the right way to check this - I missed a sentence in the msdn page. I'll send a patch to handle this in this test and yuv_color_test. Real Windows drivers seem to agree with our interpretation of CheckDeviceFormatConversion. (Sorry if this mail arrives twice. I think my mail server swallowed the last one.) Am 2014-02-13 14:52, schrieb Martin Storsjo:
There are no public defines for the YV12 and NV12 formats, although they do seem to be supported on actual D3D on windows, at least on the one machine I tested on. --- Removed unnecessary IDirect3DDevice9_SetFVF call. ---
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/NuWAAoJEN0/YqbEcdMwg+0P/iXXzioHwCQuR4fQxmaZ0iQa FB/3kQd1E2Gn/k0sV9H+Uqb0s+C6g1/QSk11Q4+KaYjmAgcp7j2BJXi81wksInRV wLix2vEqENroLxoDbVVcjEyvlLBENnkCU88ixzK2IjzDuMGrDBNX6xnpDgE7UQIT ra5JiO6hnY2J6LN78QXomwgIQgtbTURhR+NwyXbYk6uYhWGu3+JoB24Ga0NnRH/p zfNXEWYgcrW05lBUCBEwu7+7XHHaYY45l8/p5o33JqiacYJIvFlwJ/H/Kpcc4bQ1 4yky4k/K2DEwpdlhBAzsGheqs5mAZ7xCYytFH+f1kNbDAfowN9M03wgFjfecPPJa 2UENwr0otG2/NdYyqD4FbfLUQZYnAcP4OdZ2lTIE/oZqlsN7T3d7xVhfzqDjRWP+ NhsCfKFTct+v0DWZpqp9Gcyi2aOJtoxuRFpaQIUHcKnEDD6PzBCLutVVERrhI3Gy 55+j7FfH9MfDT08+EOhK+4VXu74CdIgTUaR2Hm2nZFFw9q4Awh4Ixkd4RjjGFAWP RDnNzInSeaBKFYlwHhIxt5lnnVdIsJTkRvQi+j7g3j9YBMncE88YFWWw8wqkmPaE 9QfCvMCQZp7qmf9ak8A2PfCNDQv4jx4LEoJoNjgloLm8qQq0Yu+JYRpNjyvC6MJa pfw1CcMzFR626dZ9dOW2 =69kR -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-02-13 15:49, schrieb Stefan Dösinger:
Looks good, thanks!
Wrt the testbot failures: It looks like CheckDeviceFormatConversion is in fact the right way to check this - I missed a sentence in the msdn page. I'll send a patch to handle this in this test and yuv_color_test. Real Windows drivers seem to agree with our interpretation of CheckDeviceFormatConversion. I've sent a patch (id 102467) that should take care of the testbot failures on the Windows 8 machine. The fix should conceptually work for your test as well.
I'm not entirely sure why Henri didn't ack your patches, but my guess it's because of the testbot failure or he was just waiting a day for the dust to settle. If not I'm sure he'll voice his concerns. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/U4sAAoJEN0/YqbEcdMwjqkQAJJWOztWX1qVURmKdH8Kzve8 COnAyRN4sDdexdEL3m7GzeGq269+tLPriGcePnqkqpERUYI5tRE+rixOQeojG4Ee F6o4CxoG/MOxaxTNt7ZAx5k7ZGq3Of35I8cO1pM4ENJR0VSaot1KCGjfQj7dkoU+ 1f55VHNp8JGY8Mi7bsKkKe5IZf0I3cJHtVQ9l/SKGaaee62eT5QJKBRvLpdkLxTk Eb7OlJi5zs3YWetKxEZmQS7+lvXSmZt7JsWl2BjxKKCYr3X3L54cSwjngv8TwKF8 EY0i2F9L+aPMXYqmtF5DeMlVgEVmAwSG1qTfGULaocLLu5AaR2HFiRUisRrxpkRq dq6BIFBqE9sGY4gDrJaLk9JTRg8W4zTwbX7lonMTI/wu7i2NwmIF1zo3yuypozLH GUpvoUqgys4DF6Xq+yQKg9Hedx/Eu9KzBdtQtJ5lgq8TbZuzuDtarBUZr5V2Mus0 N+gHx57wTAAzeldQ676hueVOPTH8zz3hk5TihWMA2OISyoGojNnTaaPOuiIZ4a4Y 6HZCTaWHCdMDk8Uf2P3M0Bnrh+o9lJddwToNPim8dvhI17HLIzWiThsKMHjcwK4I U9Ov4IvSdRYySAgPBXb/5Tx4L3e4wzUOogIOw9f5uyctluq5vW9Cc0z0d4siOfOe 2yNNPm+SJVbR5nmoqDHx =uLek -----END PGP SIGNATURE-----
participants (1)
-
Stefan Dösinger