Re: [PATCH] add the interfaces necessary to use the D3D11 video decoder

[Matteo Bruni]

2015-05-08 9:03 GMT+02:00 Steve Lhomme <robux4(a)videolabs.io>:
> Anyone has anything to say about this ?
>
> Thanks
>
> On Tue, May 5, 2015 at 1:52 PM, Steve Lhomme <robux4(a)videolabs.io> wrote:
> > This is needed by VLC.

Hi Steve,

some parts of the patch are clearly copypasted from the MS idl, which
is a deal breaker. While rewriting those parts try to use the wined3d
style, like putting the '*' next to the variable instead of the type.

Another potential issue (noticed by Henri) is that
D3D11_VIDEO_PROCESSOR_COLOR_SPACE uses bitfields which aren't
generally portable. I don't know if their implementation on Windows is
compatible with the one used by the OSs and architectures we support.
If that's not the case then we have a problem...

[PATCH] add the interfaces necessary to use the D3D11 video decoder

[Steve Lhomme]

On Fri, May 8, 2015 at 6:23 PM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
> 2015-05-08 9:03 GMT+02:00 Steve Lhomme <robux4(a)videolabs.io>:
> > Anyone has anything to say about this ?
> >
> > Thanks
> >
> > On Tue, May 5, 2015 at 1:52 PM, Steve Lhomme <robux4(a)videolabs.io> wrote:
> > > This is needed by VLC.
>
> Hi Steve,
>
> some parts of the patch are clearly copypasted from the MS idl, which
> is a deal breaker. While rewriting those parts try to use the wined3d
> style, like putting the '*' next to the variable instead of the type.

OK, new patch coming soon.
> Another potential issue (noticed by Henri) is that
> D3D11_VIDEO_PROCESSOR_COLOR_SPACE uses bitfields which aren't
> generally portable. I don't know if their implementation on Windows is
> compatible with the one used by the OSs and architectures we support.
> If that's not the case then we have a problem...

There are bitfields in dwrite.idl and dwrite_1.idl. For example in
DWRITE_SHAPING_GLYPH_PROPERTIES.

Thanks for the help.