Re: cmd: ensure create_full_path returns FALSE for all errors

[Marcus Meissner]

On Sat, Jun 04, 2011 at 04:37:05PM +0200, Frédéric Delanoy wrote:
> This resolves the issue from bug #27383
> ---
>  programs/cmd/builtins.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c
> index 0352e59..18e16fe 100644
> --- a/programs/cmd/builtins.c
> +++ b/programs/cmd/builtins.c
> @@ -496,6 +496,7 @@ static BOOL create_full_path(WCHAR* path)
>          WCHAR *slash;
>          DWORD last_error = GetLastError();
>          if (last_error == ERROR_ALREADY_EXISTS)
> +            ret = FALSE;
>              break;

You at least miss { } here.

Ciao, Marcus

cmd: ensure create_full_path returns FALSE for all errors

[Frédéric Delanoy]

On Sat, Jun 4, 2011 at 16:51, Marcus Meissner <marcus(a)jet.franken.de> wrote:
> On Sat, Jun 04, 2011 at 04:37:05PM +0200, Frédéric Delanoy wrote:
> > This resolves the issue from bug #27383
> > ---
> >  programs/cmd/builtins.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c
> > index 0352e59..18e16fe 100644
> > --- a/programs/cmd/builtins.c
> > +++ b/programs/cmd/builtins.c
> > @@ -496,6 +496,7 @@ static BOOL create_full_path(WCHAR* path)
> >          WCHAR *slash;
> >          DWORD last_error = GetLastError();
> >          if (last_error == ERROR_ALREADY_EXISTS)
> > +            ret = FALSE;
> >              break;
>
> You at least miss { } here.

Damn... /me feels stupid... :(

Resending