Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

[Stefan Dösinger]

Am 20.07.2010 um 18:51 schrieb Henri Verbeet:
> -            || gl_info->supported[WINE_NORMALIZED_TEXRECT])
> +            || gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT])
> I understand the WINE->WINED3D part - it's a wined3d specific thing, nothing wine global. But why did you add GL to the name?

[PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

[Henri Verbeet]

On 20 July 2010 22:05, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
> Am 20.07.2010 um 18:51 schrieb Henri Verbeet:
> > -            || gl_info->supported[WINE_NORMALIZED_TEXRECT])
> > +            || gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT])
> > I understand the WINE->WINED3D part - it's a wined3d specific thing, nothing wine global. But why did you add GL to the name?

Consistency with the enum name, and WINED3D_GL_EXT_NONE,
WINED3D_GL_EXT_COUNT and WINED3D_GL_VERSION_2_0.

[PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

[Stefan Dösinger]

Am 21.07.2010 um 13:01 schrieb Henri Verbeet:
> On 20 July 2010 22:05, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
> > Am 20.07.2010 um 18:51 schrieb Henri Verbeet:
> > > -            || gl_info->supported[WINE_NORMALIZED_TEXRECT])
> > > +            || gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT])
> > > I understand the WINE->WINED3D part - it's a wined3d specific thing, nothing wine global. But why did you add GL to the name?
>
> Consistency with the enum name, and WINED3D_GL_EXT_NONE,
> WINED3D_GL_EXT_COUNT and WINED3D_GL_VERSION_2_0.
> But those aren't extensions.

[PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

[Henri Verbeet]

On 21 July 2010 14:12, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
> Am 21.07.2010 um 13:01 schrieb Henri Verbeet:
> > On 20 July 2010 22:05, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
> > > Am 20.07.2010 um 18:51 schrieb Henri Verbeet:
> > > > -            || gl_info->supported[WINE_NORMALIZED_TEXRECT])
> > > > +            || gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT])
> > > > I understand the WINE->WINED3D part - it's a wined3d specific thing, nothing wine global. But why did you add GL to the name?
> >
> > Consistency with the enum name, and WINED3D_GL_EXT_NONE,
> > WINED3D_GL_EXT_COUNT and WINED3D_GL_VERSION_2_0.
> > But those aren't extensions.

Neither is this, which was kind of the point.

[PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

[Stefan Dösinger]

Am Mittwoch 21 Juli 2010, 14:13:59 schrieb Henri Verbeet:
> On 21 July 2010 14:12, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
> > Am 21.07.2010 um 13:01 schrieb Henri Verbeet:
> > > Consistency with the enum name, and WINED3D_GL_EXT_NONE,
> > > WINED3D_GL_EXT_COUNT and WINED3D_GL_VERSION_2_0.
> >
> > But those aren't extensions.
>
> Neither is this, which was kind of the point.
> OK with me in this case.

I'd consider normalized_texrect a GL extension for WineD3D's purposes, mostly 
due to lack of reasons not to consider it a GL extension, but I am fine with 
either way.

[PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

[Henri Verbeet]

On 21 July 2010 18:29, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
> I'd consider normalized_texrect a GL extension for WineD3D's purposes, mostly
> due to lack of reasons not to consider it a GL extension,
> If it's not on http://www.opengl.org/registry/, or at least making
> progress towards going there, it's not a GL extension.