Re: winemenubuilder: Return error for missing link in InvokeShellLinkerForURL function
Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote:
--- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -3030,7 +3030,7 @@ static BOOL InvokeShellLinkerForURL( IUniformResourceLocatorW *url, LPCWSTR link if ( !link ) { WINE_ERR("Link name is null\n"); - return TRUE; + return FALSE; }
This doesn't follow the behaviour of other failure cases in this helper. -- Dmitry.
On Mon, Dec 16, 2013 at 2:58 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote:
--- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -3030,7 +3030,7 @@ static BOOL InvokeShellLinkerForURL( IUniformResourceLocatorW *url, LPCWSTR link if ( !link ) { WINE_ERR("Link name is null\n"); - return TRUE; + return FALSE; }
This doesn't follow the behaviour of other failure cases in this helper.
-- Dmitry.
The makes error in this case it in line with similar InvokeShellLinker() function. Both function are called in a similar way, and the latter already returns TRUE for warnings (and FALSE for NULL link) Granted, this file would need some restructuring, but this is beyond the scope of this patch. -- Frédéric Delanoy
participants (2)
-
Dmitry Timoshkov -
Frédéric Delanoy