Re: rpcrt4: [1/2] Improve stub for I_RpcBindingInqTransportType, with test
Detlef Riekenberg <wine.dev(a)web.de> wrote:
@@ -848,6 +848,10 @@ RPC_STATUS WINAPI I_RpcBindingInqTransportType( RPC_BINDING_HANDLE Binding, unsi {
FIXME( "(%p,%p): stub\n", Binding, Type); + + /* NT: RPC_S_NO_CONTEXT_AVAILABLE, 9x: RPC_S_NO_CALL_ACTIVE */ + if (!Binding) return RPC_S_NO_CONTEXT_AVAILABLE;
According to your test this should be if (!Binding || !Type) return RPC_S_NO_CONTEXT_AVAILABLE; Also the comment doesn't belong here, it's ok to have in the test though. -- Dmitry.
On So, 2008-08-10 at 12:21 +0900, Dmitry Timoshkov wrote:
+ /* NT: RPC_S_NO_CONTEXT_AVAILABLE, 9x: RPC_S_NO_CALL_ACTIVE */ + if (!Binding) return RPC_S_NO_CONTEXT_AVAILABLE;
According to your test this should be if (!Binding || !Type) return RPC_S_NO_CONTEXT_AVAILABLE;
No, your asumption does not match the test. My test show, that Windows does not care about Type, when Binding is NULL: => Binding must be checked first and *Type is not touched. For your code above, the test must create and use a valid binding with "Type == NULL".
Also the comment doesn't belong here, it's ok to have in the test though. OK.
-- By by ... Detlef
participants (2)
-
Detlef Riekenberg -
Dmitry Timoshkov