Re: [PATCH] usp10/tests: Use BOOL variable for BOOL retval (PVS-Studio)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=17515

Your paranoid android.


=== w1064 (32 bit usp10) ===
usp10.c:1244: Test failed: 0: uJustification incorrect (0)
usp10.c:1244: Test failed: 1: uJustification incorrect (0)
usp10.c:1244: Test failed: 2: uJustification incorrect (0)
usp10.c:1244: Test failed: 3: uJustification incorrect (0)
usp10.c:1244: Test failed: 4: uJustification incorrect (0)
usp10.c:1244: Test failed: 5: uJustification incorrect (0)
usp10.c:1244: Test failed: 6: uJustification incorrect (0)
usp10.c:1244: Test failed: 7: uJustification incorrect (0)
usp10.c:1244: Test failed: 8: uJustification incorrect (0)
usp10.c:1244: Test failed: 9: uJustification incorrect (0)
usp10.c:1260: Test failed: 3: uJustification incorrect (0)
usp10.c:1260: Test failed: 5: fDiacritic incorrect (1)
usp10.c:1260: Test failed: 5: fZeroWidth incorrect (1)
usp10.c:1260: Test failed: 15: fDiacritic incorrect (1)
usp10.c:1260: Test failed: 15: fZeroWidth incorrect (1)

[PATCH] usp10/tests: Use BOOL variable for BOOL retval (PVS-Studio)

[Nikolay Sivov]

On 20.10.2015 16:12, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=17515
>
> Your paranoid android.
>
> === w1064 (32 bit usp10) ===
> usp10.c:1244: Test failed: 0: uJustification incorrect (0)
> usp10.c:1244: Test failed: 1: uJustification incorrect (0)
> usp10.c:1244: Test failed: 2: uJustification incorrect (0)
> usp10.c:1244: Test failed: 3: uJustification incorrect (0)
> usp10.c:1244: Test failed: 4: uJustification incorrect (0)
> usp10.c:1244: Test failed: 5: uJustification incorrect (0)
> usp10.c:1244: Test failed: 6: uJustification incorrect (0)
> usp10.c:1244: Test failed: 7: uJustification incorrect (0)
> usp10.c:1244: Test failed: 8: uJustification incorrect (0)
> usp10.c:1244: Test failed: 9: uJustification incorrect (0)
> usp10.c:1260: Test failed: 3: uJustification incorrect (0)
> usp10.c:1260: Test failed: 5: fDiacritic incorrect (1)
> usp10.c:1260: Test failed: 5: fZeroWidth incorrect (1)
> usp10.c:1260: Test failed: 15: fDiacritic incorrect (1)
> usp10.c:1260: Test failed: 15: fZeroWidth incorrect (1)

Those are existing failures, only happening on Win10 I think.