Re: shell32: Check registry entry for cpl files (in standard control panel)

[Juan Lang]

Hi Owen,

@@ -40,6 +41,8 @@

 WINE_DEFAULT_DEBUG_CHANNEL(shlctrl);

+static void Control_RegisterRegistryApplets(HWND hWnd, CPanel *panel,
HKEY hkey_root, LPCSTR szRepPath);
+
+    /* now check for cpls in the registry */
+

Style nit:  get rid of that blank line.

+    Control_RegisterRegistryApplets(hWnd, panel, HKEY_LOCAL_MACHINE,
"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Control Panel\\Cpls");
+    Control_RegisterRegistryApplets(hWnd, panel, HKEY_CURRENT_USER,
"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Control Panel\\Cpls");

Prefer WCHAR strings to char strings.  You can declare a string
constant at the beginning of the function, next to wszAllCpl.

@@ -340,9 +345,38 @@ static	void	Control_DoWindow(CPanel* panel, HWND
hWnd, HINSTANCE hInst)
(snip)
+static void Control_RegisterRegistryApplets(HWND hWnd, CPanel *panel,
HKEY hkey_root, LPCSTR szRepPath)

Style nit:  put Control_RegisterRegistryApplets above Control_DoWindow
to avoid adding the prototype at the top of the file.
--Juan

shell32: Check registry entry for cpl files (in standard control panel)

[Owen Rudge]

Hi Juan,
> Style nit:  get rid of that blank line.
> Prefer WCHAR strings to char strings.  You can declare a string
> constant at the beginning of the function, next to wszAllCpl.
> Style nit:  put Control_RegisterRegistryApplets above Control_DoWindow
> to avoid adding the prototype at the top of the file.

I've submitted an updated patch to wine-patches now. Thanks.

-- 
Owen Rudge
http://www.owenrudge.net/