Re: [1/5] wined3d: Don't check the FBO status if FIXMEs are off

[Henri Verbeet]

On 24 May 2011 22:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> I put the fixme checks outside context_check_fbo_status because the ENTER_GL() / LEAVE_GL()
> locking is more expensive than the FBO validation itself. Moving the locking into the function

I'm not sure that's really worth it. If the GL lock is really such a
concern, you should probably change the calls in context.c to already
be under the GL lock anyway. You can easily change
context_apply_draw_buffers() for example to require locking by the
caller.

[1/5] wined3d: Don't check the FBO status if FIXMEs are off

[Stefan Dösinger]

On Tuesday 24 May 2011 22:57:34 Henri Verbeet wrote:
> I'm not sure that's really worth it. If the GL lock is really such a
> concern, you should probably change the calls in context.c to already
> be under the GL lock anyway. You can easily change
> context_apply_draw_buffers() for example to require locking by the
> caller.
> I planned to do this on top of this patch, but it turned out to be way easier 
> than expected. Please ignore this patch for now. The others should still apply 
> though.