Re: [4/5] shlwapi/tests: Test for an unchanged buffer when cchMax=0 in StrFromTimeInterval

[Marcus Meissner]

On Sat, Aug 06, 2011 at 06:54:48AM -0700, Scott Ritchie wrote:
> ---
>  dlls/shlwapi/tests/string.c |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)

> diff --git a/dlls/shlwapi/tests/string.c b/dlls/shlwapi/tests/string.c
> index 68028d7..ecc58cc 100644
> --- a/dlls/shlwapi/tests/string.c
> +++ b/dlls/shlwapi/tests/string.c
> @@ -615,6 +615,14 @@ static void test_StrFromTimeIntervalW(void)
>         result->return_value, ret);
>      ok(!strcmp(result->time_interval, szBuff), "Formatted %d %d wrong\n",
>         result->ms, result->digits);
> +
> +    /* Test with 0 parameter, this should not change the buffer */
> +    MultiByteToWideChar(0,0,"dontchange",-1,szBuffW,sizeof(szBuffW));

/sizeof(szBuffW[0]) missing.

Ciao, Marcus

[4/5] shlwapi/tests: Test for an unchanged buffer when cchMax=0 in StrFromTimeInterval

[Scott Ritchie]

On 08/06/2011 06:59 AM, Marcus Meissner wrote:
> On Sat, Aug 06, 2011 at 06:54:48AM -0700, Scott Ritchie wrote:
> > ---
> >  dlls/shlwapi/tests/string.c |   15 +++++++++++++++
> >  1 files changed, 15 insertions(+), 0 deletions(-)
> > diff --git a/dlls/shlwapi/tests/string.c b/dlls/shlwapi/tests/string.c
> > index 68028d7..ecc58cc 100644
> > --- a/dlls/shlwapi/tests/string.c
> > +++ b/dlls/shlwapi/tests/string.c
> > @@ -615,6 +615,14 @@ static void test_StrFromTimeIntervalW(void)
> >         result->return_value, ret);
> >      ok(!strcmp(result->time_interval, szBuff), "Formatted %d %d wrong\n",
> >         result->ms, result->digits);
> > +
> > +    /* Test with 0 parameter, this should not change the buffer */
> > +    MultiByteToWideChar(0,0,"dontchange",-1,szBuffW,sizeof(szBuffW));
>
> /sizeof(szBuffW[0]) missing.
>
> Ciao, Marcus

Indeed it was.  Not bad for my first attempt at C in 10 years :D

Thanks,
Scott Ritchie