[PATCH] advapi32/tests: The preferred UI language check must be case insensitive.

[Francois Gouget]

This avoid skipping the test for the French locale.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
---
It looks like langW was in lowercase back when w10pro64 was running 
Windows 10 2004; but it's uppercase in 21H1 which is why the 
advapi32:lsa failure disappeared for the French locale.

 dlls/advapi32/tests/lsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/advapi32/tests/lsa.c b/dlls/advapi32/tests/lsa.c
index f8c822a7de2..58ab37c9aa9 100644
--- a/dlls/advapi32/tests/lsa.c
+++ b/dlls/advapi32/tests/lsa.c
@@ -403,7 +403,7 @@ static void test_LsaLookupSids(void)
         check_unicode_string(&names[0].Name, L"Everyone");
     else if (wcscmp(langW, L"0407") == 0) /* German */
         check_unicode_string(&names[0].Name, L"Jeder");
-    else if (wcscmp(langW, L"040C") == 0) /* French */
+    else if (wcsicmp(langW, L"040C") == 0) /* French */
         check_unicode_string(&names[0].Name, L"Tout le monde");
     else
         trace("<Everyone-group>.Name=%s\n", debugstr_w(names[0].Name.Buffer));
-- 
2.30.2

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=103423

Your paranoid android.


=== debiant2 (32 bit French report) ===

advapi32:
lsa.c:407: Test failed: expected L"Tout le monde", got L"Everyone"

[Francois Gouget]

On Mon, 6 Dec 2021, Francois Gouget wrote:
> This avoid skipping the test for the French locale.
>
> Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
> ---
> It looks like langW was in lowercase back when w10pro64 was running 
> Windows 10 2004; but it's uppercase in 21H1 which is why the 
> advapi32:lsa failure disappeared for the French locale.

I confused two issues:
* "Everyone" was not translated when w10pro64 was running Windows 10 
  2004 which caused the test to fail. This proves that langW was all 
  uppercase then too.

* And it's only in Wine that langW is lowercase. Windows 7, Windows 10 
  2004 and 21H1 all put it in uppercase. So the right fix is probably to 
  modify Wine so GetSystemPreferredUILanguages() returns an uppercase 
  string.

So I think it's best to ignore this patch.


-- 
Francois Gouget <fgouget(a)codeweavers.com>