Re: patch for cups printers
--- winehq/dlls/gdi/printdrv.c Thu Mar 28 17:22:05 2002 +++ wine/dlls/gdi/printdrv.c Mon Apr 29 15:29:42 2002 @@ -482,6 +482,8 @@
if (!strncmp("LPR:",pszOutput,4)) sprintf(psCmd,"|lpr -P%s",pszOutput+4); + if (!strncmp("CUPS:",pszOutput,4)) + sprintf(psCmd,"|lp -d%s",pszOutput+4); else { HKEY hkey;
This is wrong, the else { } is handled in the LPR: case too so you break /etc/printcap based printing. Ciao, Marcus
Attached is a correction for yesterday's lame printing patch. This corrects the string length errors and the LPR else case. On Tue, Apr 30, 2002 at 06:43:11AM +0200, Marcus Meissner wrote:
--- winehq/dlls/gdi/printdrv.c Thu Mar 28 17:22:05 2002 +++ wine/dlls/gdi/printdrv.c Mon Apr 29 15:29:42 2002 @@ -482,6 +482,8 @@
if (!strncmp("LPR:",pszOutput,4)) sprintf(psCmd,"|lpr -P%s",pszOutput+4); + if (!strncmp("CUPS:",pszOutput,4)) + sprintf(psCmd,"|lp -d%s",pszOutput+4); else { HKEY hkey;
This is wrong, the else { } is handled in the LPR: case too so you break /etc/printcap based printing.
Ciao, Marcus
-- michael cardenas lead windows compatibility engineer lindows.com "Be the change you want to see in the world" -Mahatma Gandhi
Just a very late addition to this discussion: I'm using cups 1.1.12 from Suse 8.0 and "cat file | lpr -Pprintername" works fine. ciao Jörg
- if (!strncmp("LPR:",pszOutput,4)) + if (!strncmp("CUPS:",pszOutput,5)) + sprintf(psCmd,"|lp -d%s",pszOutput+5); + else if (!strncmp("LPR:",pszOutput,4)) sprintf(psCmd,"|lpr -P%s",pszOutput+4); else
-- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.
Yes, Duane Clark pointed this out already. Apparently, the lpr that shpis with lindowsOS is incomplete for some reason. We're looking into fixing it. I just submitted the patch because I think it is more correct, and there is a possibility that other systems that have cups might not have complete lpr implementations. On Tue, Apr 30, 2002 at 09:42:07PM +0200, Joerg Mayer wrote:
Just a very late addition to this discussion: I'm using cups 1.1.12 from Suse 8.0 and "cat file | lpr -Pprintername" works fine.
ciao J?rg
- if (!strncmp("LPR:",pszOutput,4)) + if (!strncmp("CUPS:",pszOutput,5)) + sprintf(psCmd,"|lp -d%s",pszOutput+5); + else if (!strncmp("LPR:",pszOutput,4)) sprintf(psCmd,"|lpr -P%s",pszOutput+4); else
-- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.
-- michael cardenas lead windows compatibility engineer lindows.com "Be the change you want to see in the world" -Mahatma Gandhi
Michael Cardenas <michael.cardenas(a)lindows.com> writes:
Apparently, the lpr that shpis with lindowsOS is incomplete for some reason. We're looking into fixing it. I just submitted the patch because I think it is more correct, and there is a possibility that other systems that have cups might not have complete lpr implementations.
Of course there's also the possibility that some systems might have a working lpr and a broken lp... It may be a better idea to make this configurable. -- Alexandre Julliard julliard(a)winehq.com
Well, with my patch, if the registry entry says LPR: it will use lpr and if it says CUPS: it will use lp. How would you like to make it configurable? On Wed, May 01, 2002 at 11:11:28AM -0700, Alexandre Julliard wrote:
Michael Cardenas <michael.cardenas(a)lindows.com> writes:
Apparently, the lpr that shpis with lindowsOS is incomplete for some reason. We're looking into fixing it. I just submitted the patch because I think it is more correct, and there is a possibility that other systems that have cups might not have complete lpr implementations.
Of course there's also the possibility that some systems might have a working lpr and a broken lp... It may be a better idea to make this configurable.
-- Alexandre Julliard julliard(a)winehq.com
-- michael cardenas lead windows compatibility engineer lindows.com "Be the change you want to see in the world" -Mahatma Gandhi
Michael Cardenas <michael.cardenas(a)lindows.com> writes:
Well, with my patch, if the registry entry says LPR: it will use lpr and if it says CUPS: it will use lp.
How would you like to make it configurable?
I don't know exactly. At the GDI level, obviously if LPR: means lpr then lp should be specified with LP: not CUPS:. At the winspool level we should probably use the cups API as Huw mentioned. -- Alexandre Julliard julliard(a)winehq.com
participants (4)
-
Alexandre Julliard -
Joerg Mayer -
Marcus Meissner -
Michael Cardenas