Alexandre, Can we get the Module name and/or modified files added back to the subject line for CVS? IHMO, this is much more useful than knowing who submitted the patch. Thankyou, Ron Jensen On Fri, 2005-12-02 at 09:43 -0600, Alexandre Julliard wrote:
ChangeSet ID: 21634 CVSROOT: /opt/cvs-commit Module name: CVSROOT Changes by: julliard(a)winehq.org 2005/12/02 09:43:52
Modified files: . : loginfo
Log message: Don't send mail to wine-cvs for the wine module, this will be done from the git repository.
Patch: http://cvs.winehq.org/patch.py?id=21634
Old revision New revision Changes Path 1.50 1.51 +2 -1 CVSROOT/loginfo
Index: CVSROOT/loginfo diff -u -p CVSROOT/loginfo:1.50 CVSROOT/loginfo:1.51 --- CVSROOT/loginfo:1.50 2 Dec 2005 15:43:52 -0000 +++ CVSROOT/loginfo 2 Dec 2005 15:43:52 -0000 @@ -28,7 +28,8 @@ # Use this for testing ^test /usr/bin/perl $CVSROOT/CVSROOT/log_accum -m testing(a)winehq.org -f $CVSROOT/CVSROOT/commitlog -S -s %p %s
+^wine /usr/bin/perl $CVSROOT/CVSROOT/log_accum -f $CVSROOT/CVSROOT/commitlog -S -s %p %s + # All others go to wine-cvs -^wine /usr/bin/perl $CVSROOT/CVSROOT/log_accum -m wine-cvs(a)winehq.org -f $CVSROOT/CVSROOT/commitlog -L 200 -p -S -s %p %s DEFAULT /usr/bin/perl $CVSROOT/CVSROOT/log_accum -m wine-cvs(a)winehq.org -f $CVSROOT/CVSROOT/commitlog -P winehq -L 200 -p -c -S -s %p %s
Ron Jensen <wino(a)jentronics.com> writes:
Alexandre,
Can we get the Module name and/or modified files added back to the subject line for CVS? IHMO, this is much more useful than knowing who submitted the patch.
Well, I think having some description of what the patch is about is more useful than a truncated file list, but if the general feeling is that the file list is better I can put this back. -- Alexandre Julliard julliard(a)winehq.org
On 12/2/05, Alexandre Julliard <julliard(a)winehq.org> wrote:
Ron Jensen <wino(a)jentronics.com> writes:
Alexandre,
Can we get the Module name and/or modified files added back to the subject line for CVS? IHMO, this is much more useful than knowing who submitted the patch.
Well, I think having some description of what the patch is about is more useful than a truncated file list, but if the general feeling is that the file list is better I can put this back.
One vote for patch description instead of file list here. The only thing I would like to see that the file list provided is the area affected by the patch. Say one of Rob's OLE patches is committed, then it would be nice to see OLE in the subject somewhere, though it's not essential. -- James Hawkins
Am Freitag, den 02.12.2005, 21:00 +0100 schrieb Alexandre Julliard:
Can we get the Module name and/or modified files added back to the subject line for CVS? IHMO, this is much more useful than knowing who submitted the patch.
Well, I think having some description of what the patch is about is more useful than a truncated file list, but if the general feeling is that the file list is better I can put this back.
I would like to see that the Subject-line again start with the Subdir to see the Area, the Patch belongs to. - Easy to filter out the patches, I'm not Interested in. - When find a Patch for an Area that an App has Problems with, it's a good time to test the Functionality of the App again -- By By ... ... Detlef
Well, I think having some description of what the patch is about is more useful than a truncated file list, but if the general feeling is that the file list is better I can put this back.
What about all three informations: a.) author b.) affected directory, like "[dlls/ole32]" c.) beginning of the changelog An example would be: "Michael Jung: [dlls/shell32] Implemented scrolling during drag&drop for the shellview class" Another idea would be to replace b.) and c.) by the original patch mail subject. This typically already contains the affected code section, for example "WINED3D: Return the correct parent in IWineD3DPixelShaderImpl_GetParent". While searching for good examples I good even more comfortable with the second idea: The changelog can be quite long, and only displaying some truncated part of it may not be that good. Using the mail subject instead is better because the patch writer already had the possibility to condense the change into some meaningfull one line-comment. Regards, Martin
Am Samstag, den 03.12.2005, 13:43 +0100 schrieb Martin Fuchs:
What about all three informations: a.) author b.) affected directory, like "[dlls/ole32]" c.) beginning of the changelog
IMHO, best of all is starting with the affected directory and use the subject for c. Benefit: Simple sort "by Subject" and the changes for a specific dll/program are all together, no matter, who created the Patch.
An example would be: "Michael Jung: [dlls/shell32] Implemented scrolling during drag&drop for the shellview class"
"dlls/shell32 [Michael Jung] Implemented scrolling during drag&drop for the shellview class"
Another idea would be to replace b.) and c.) by the original patch mail subject. This typically already contains the affected code section, for example "WINED3D: Return the correct parent in IWineD3DPixelShaderImpl_GetParent".
So, if the part before the colon has no space, try it as a path when not found, try to prefix with "dll/" or "programs/" When the part is valid, use it as the start of the commit-Subject. When the part is invalid, use the Path of the First affected File as the start of the commit-Subject. ---- Your Example: "WINED3D [Creator] Return the correct parent in IWineD3DPixelShaderImpl_GetParent" -- By By ... ... Detlef
Martin Fuchs <fuchs.martin(a)gmail.com> writes:
While searching for good examples I good even more comfortable with the second idea: The changelog can be quite long, and only displaying some truncated part of it may not be that good. Using the mail subject instead is better because the patch writer already had the possibility to condense the change into some meaningfull one line-comment.
Yes, I think that's the way to go. -- Alexandre Julliard julliard(a)winehq.org
participants (5)
-
Alexandre Julliard -
Detlef Riekenberg -
James Hawkins -
Martin Fuchs -
Ron Jensen