Re: [PATCH 2/2] wined3d: Prevent console spamming in drawPrimitive.

[H. Verbeet]

On 18/04/2008, Alexander Dorofeyev <alexd4(a)inbox.lv> wrote:
> Fixes massive slowdown in games like Aliens vs Predator 2.

If you care about performance you should always run with
WINEDEBUG="-all" anyway.

[PATCH 2/2] wined3d: Prevent console spamming in drawPrimitive.

[Stefan Dösinger]

Am Samstag, 19. April 2008 02:36:39 schrieb H. Verbeet:
> On 18/04/2008, Alexander Dorofeyev <alexd4(a)inbox.lv> wrote:
> > Fixes massive slowdown in games like Aliens vs Predator 2.
>
> If you care about performance you should always run with
> WINEDEBUG="-all" anyway.
> I think it is valid to prevent such flooding though, because with 
> WINEDEBUG=-all you might miss helpful errors as well. Even if -all is not set 
> it is usually quite hard to see a single legitimate fixme in such a flood

[PATCH 2/2] wined3d: Prevent console spamming in drawPrimitive.

[H. Verbeet]

On 19/04/2008, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> Am Samstag, 19. April 2008 02:36:39 schrieb H. Verbeet:
> > On 18/04/2008, Alexander Dorofeyev <alexd4(a)inbox.lv> wrote:
> > > Fixes massive slowdown in games like Aliens vs Predator 2.
> >
> > If you care about performance you should always run with
> > WINEDEBUG="-all" anyway.
>
> I think it is valid to prevent such flooding though, because with
>  WINEDEBUG=-all you might miss helpful errors as well. Even if -all is not set
>  it is usually quite hard to see a single legitimate fixme in such a flood

Oh, I'm not opposed to the patch itself, preventing the log from
getting spammed is a good thing. Just saying performance is the wrong
reason.

[PATCH 2/2] wined3d: Prevent console spamming in drawPrimitive.

[Stefan Dösinger]

Am Samstag, 19. April 2008 07:19:17 schrieb H. Verbeet:
> Oh, I'm not opposed to the patch itself, preventing the log from
> getting spammed is a good thing. Just saying performance is the wrong
> reason.
> Agreed