Re: [3/5] wined3d: create IWineD3DDeviceImpl_ClearSurface routine

[Stefan Dösinger]

Am Montag, 17. Dezember 2007 04:56:14 schrieb Alexander Dorofeyev:
> ---
>    dlls/wined3d/device.c          |  162
> ++++++++++++++++++++++++++++++++++++++++ dlls/wined3d/wined3d_private.h |  
>  3 +
>    2 files changed, 165 insertions(+), 0 deletions(-)
> This patch, and 4 and 5 look good to me content wise, but patch 3 doesn't make 
> much sense without either 4 or 5. It's up to AJ to decide, but you could 
> propably combine patches 3 and 4(and keep 5 separate).

[3/5] wined3d: create IWineD3DDeviceImpl_ClearSurface routine

[Alexander Dorofeyev]

Hi.

There was a bit of a problem with combining 3 & 4, because diff mixes 
parts of two functions together and the patch is a total mess that would 
be difficult to review. 2 separate patches looked like an easiest way 
around that. If that's not ok I can try other workarounds, may be 
experiment with some diff options or combine 3 & 5.

Stefan Dösinger wrote:
> Am Montag, 17. Dezember 2007 04:56:14 schrieb Alexander Dorofeyev:
> > ---
> >    dlls/wined3d/device.c          |  162
> > ++++++++++++++++++++++++++++++++++++++++ dlls/wined3d/wined3d_private.h |  
> >  3 +
> >    2 files changed, 165 insertions(+), 0 deletions(-)
> > This patch, and 4 and 5 look good to me content wise, but patch 3 doesn't make 
> > much sense without either 4 or 5. It's up to AJ to decide, but you could 
> > propably combine patches 3 and 4(and keep 5 separate).