[PATCH 1/6] winebuild: Don't include aliases in importlib .def files.

[Jacek Caban]

LLVM-Bug: https://reviews.llvm.org/D66617

We currently depend on binutils-specific quirk in aliases handling. 
Aliases are not needed to generate importlib anyway, so just skip them.

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  tools/winebuild/build.h  | 2 +-
  tools/winebuild/import.c | 2 +-
  tools/winebuild/main.c   | 2 +-
  tools/winebuild/spec32.c | 7 ++++---
  4 files changed, 7 insertions(+), 6 deletions(-)

[Martin Storsjö]

On Sun, 25 Aug 2019, Jacek Caban wrote:
> LLVM-Bug: https://reviews.llvm.org/D66617
>
> We currently depend on binutils-specific quirk in aliases handling.

That's a very kind way of saying it :-) I'd word it more like 
"llvm-dlltool has got a bug in handling symbol decoration for certain 
combinations of decorations in export aliases (with single '=', contrary 
to double '=')"
> Aliases are not needed to generate importlib anyway, so just skip them.

Yes, that's correct.

// Martin

[Jacek Caban]

On 8/25/19 8:42 PM, Martin Storsjö wrote:
> On Sun, 25 Aug 2019, Jacek Caban wrote:
> > LLVM-Bug: https://reviews.llvm.org/D66617
> >
> > We currently depend on binutils-specific quirk in aliases handling.
>
> That's a very kind way of saying it :-) I'd word it more like 
> "llvm-dlltool has got a bug in handling symbol decoration for certain 
> combinations of decorations in export aliases (with single '=', 
> contrary to double '=')"

Yeah, I could have worded it more accurately. Alexandre, please just 
drop the comment.


Thanks,

Jacek