Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.
Alex Henrie <alexhenrie24(a)gmail.com> writes:
I was asked to split this patch up, so I did. The complaint about the last version was "You are still overflowing the source." I have not been able to find any test case that my implementation handled incorrectly, however, I did find that (*src == 0 && srclen < 0) will never evaluate to true, so I removed this if statement from the code. I also changed example #2 in the tests to be slightly more stringent, but the last patch would also have passed.
If this patch series is rejected, please show me a test case that demonstrates what I am doing wrong.
You don't have a single test with an explicit source length, so obviously you are not going to find problems in that area. Like I said, you need a lot more tests. -- Alexandre Julliard julliard(a)winehq.org
2012/9/3 Alexandre Julliard <julliard(a)winehq.org>:
You don't have a single test with an explicit source length, so obviously you are not going to find problems in that area. Like I said, you need a lot more tests.
example_2 already tests an explicit source length. In all the other examples srclen = strlen(src) + 1, see http://source.winehq.org/git/wine.git/blob/2097c5ddb6bec24cf4bbd440a6f401cfa... So again, what specific additional test, or what specific change to the existing tests, do you want to see? -Alex
Alex Henrie <alexhenrie24(a)gmail.com> writes:
2012/9/3 Alexandre Julliard <julliard(a)winehq.org>:
You don't have a single test with an explicit source length, so obviously you are not going to find problems in that area. Like I said, you need a lot more tests.
example_2 already tests an explicit source length. In all the other examples srclen = strlen(src) + 1, see http://source.winehq.org/git/wine.git/blob/2097c5ddb6bec24cf4bbd440a6f401cfa...
So again, what specific additional test, or what specific change to the existing tests, do you want to see?
Think about what the code is doing, and how to test it. In particular spend some time thinking about the source length parameter. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alex Henrie -
Alexandre Julliard