Re: shell32 patch 20

[Dmitry Timoshkov]

"Martin Fuchs" <martin-fuchs(a)gmx.net> wrote:
> Changelog:
> - don't link directly to NTDLL; use MultiByteToWideChar() instead of RtlCreateUnicodeStringFromAsciiz()

Why do you need that?

-- 
Dmitry.

shell32 patch 20

[Martin Fuchs]

> > Changelog:
> > - don't link directly to NTDLL; use MultiByteToWideChar() instead of
> >  RtlCreateUnicodeStringFromAsciiz()
>
> Why do you need that?

RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in PSDK.

Regards,

    Martin

shell32 patch 20

[Dmitry Timoshkov]

"Martin Fuchs" <martin-fuchs(a)gmx.net> wrote:
> > > Changelog:
> > > - don't link directly to NTDLL; use MultiByteToWideChar() instead of
> > >  RtlCreateUnicodeStringFromAsciiz()
> >
> > Why do you need that?
>
> RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in PSDK.

That doesn't justify the change IMO. There are lots of places in Wine
using that construct, and it's much more convenient and avoids code
duplication (with a possibility of adding bugs in even such a simple
case).

-- 
Dmitry.

shell32 patch 20

[Steven Edwards]

Hi Dmitry,
--- Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> > RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor
> > in PSDK.
>
> That doesn't justify the change IMO. There are lots of places in Wine
> using that construct, and it's much more convenient and avoids code
> duplication (with a possibility of adding bugs in even such a simple
> case).

Well I would agree with you if it was just not defined in Mingw but
there is nothing we can do about getting Microsoft to add it to the
PSDK. If we want to build/test on MS_VC what are we to do?

Thanks
Steven



__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free web site building tool. Try it!
http://webhosting.yahoo.com/ps/sb/

shell32 patch 20

[Dmitry Timoshkov]

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote:
> Well I would agree with you if it was just not defined in Mingw but
> there is nothing we can do about getting Microsoft to add it to the
> PSDK. If we want to build/test on MS_VC what are we to do?

Microsoft provided headers and libraries usually miss a lot of things,
sometimes even documented ones. So, I don't think that screwing Wine
source due to that fact is worth the trouble.

-- 
Dmitry.