Hack for the '-pthread' at make depend
On my configuration, the 'artsc-config' script outputs '-pthread' along with the '-Isth' entries. That broke the 'makedep' procedure. It's trivial. The following patch handles this.
"P. Christeas" <p_christ(a)hol.gr> writes:
On my configuration, the 'artsc-config' script outputs '-pthread' along with the '-Isth' entries. That broke the 'makedep' procedure. It's trivial. The following patch handles this.
The right fix is to get rid of that option at configure time (or better get rid of the config script at all, this stuff is broken anyway). -- Alexandre Julliard julliard(a)winehq.com
"P. Christeas" <p_christ(a)hol.gr> writes:
On my configuration, the 'artsc-config' script outputs '-pthread' along with the '-Isth' entries. That broke the 'makedep' procedure. It's trivial. The following patch handles this.
The right fix is to get rid of that option at configure time (or better get rid of the config script at all, this stuff is broken anyway).
I thought of that when I was trying to see why the make had been broken. Unfortunately, the artsc-config script is not within "our" reach. Isn't the makedep utility supposed to have compiler's options as parameters? FYI, I haven't managed to complete the make procedure anyway. It seems that the 2.6.0 kernel headers (/usr/include/linux/) wrt. the scsi ones have some trouble: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o cdrom.o cdrom.c In file included from cdrom.c:47: /usr/include/scsi/scsi.h:203: error: syntax error before "u8" /usr/include/scsi/scsi.h:205: error: syntax error before "_r2" /usr/include/scsi/scsi.h:206: error: syntax error before "block_desc_length" /usr/include/scsi/scsi.h:207: error: syntax error before "density" /usr/include/scsi/scsi.h:208: error: syntax error before "number_blocks_hi" /usr/include/scsi/scsi.h:209: error: syntax error before "number_blocks_med" /usr/include/scsi/scsi.h:210: error: syntax error before "number_blocks_lo" /usr/include/scsi/scsi.h:211: error: syntax error before "_r3" /usr/include/scsi/scsi.h:212: error: syntax error before "block_length_hi" /usr/include/scsi/scsi.h:213: error: syntax error before "block_length_med" /usr/include/scsi/scsi.h:214: error: syntax error before "block_length_lo" /usr/include/scsi/scsi.h:221: error: syntax error before "u8" In file included from ../../include/winbase.h:22, from cdrom.c:79: ../../include/winerror.h:43:1: warning: "FAILED" redefined In file included from cdrom.c:47: /usr/include/scsi/scsi.h:301:1: warning: this is the location of the previous definition
"P. Christeas" <p_christ(a)hol.gr> writes:
I thought of that when I was trying to see why the make had been broken. Unfortunately, the artsc-config script is not within "our" reach. Isn't the makedep utility supposed to have compiler's options as parameters?
No, how could it? There's no way to know about all possible options of all possible compilers. We should simply not use that broken config script at all, and look for the header files ourselves. -- Alexandre Julliard julliard(a)winehq.com
On Sat, Jan 03, 2004 at 10:02:10AM -0800, Alexandre Julliard wrote:
"P. Christeas" <p_christ(a)hol.gr> writes:
I thought of that when I was trying to see why the make had been broken. Unfortunately, the artsc-config script is not within "our" reach. Isn't the makedep utility supposed to have compiler's options as parameters?
No, how could it? There's no way to know about all possible options of all possible compilers. We should simply not use that broken config script at all, and look for the header files ourselves.
Wouldn't it make more sense to ask the authors of the artsc-config script to fix it? Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.
... FYI, I haven't managed to complete the make procedure anyway. It seems that the 2.6.0 kernel headers (/usr/include/linux/) wrt. the scsi ones have some trouble: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o cdrom.o cdrom.c In file included from cdrom.c:47: /usr/include/scsi/scsi.h:203: error: syntax error before "u8" /usr/include/scsi/scsi.h:205: error: syntax error before "_r2" /usr/include/scsi/scsi.h:206: error: syntax error before "block_desc_length" /usr/include/scsi/scsi.h:207: error: syntax error before "density" /usr/include/scsi/scsi.h:208: error: syntax error before "number_blocks_hi" /usr/include/scsi/scsi.h:209: error: syntax error before "number_blocks_med" /usr/include/scsi/scsi.h:210: error: syntax error before "number_blocks_lo" /usr/include/scsi/scsi.h:211: error: syntax error before "_r3" /usr/include/scsi/scsi.h:212: error: syntax error before "block_length_hi" /usr/include/scsi/scsi.h:213: error: syntax error before "block_length_med" /usr/include/scsi/scsi.h:214: error: syntax error before "block_length_lo" /usr/include/scsi/scsi.h:221: error: syntax error before "u8" In file included from ../../include/winbase.h:22, from cdrom.c:79: ../../include/winerror.h:43:1: warning: "FAILED" redefined In file included from cdrom.c:47: /usr/include/scsi/scsi.h:301:1: warning: this is the location of the previous definition
Good news. I 've just seen this at LKML : http://marc.theaimsgroup.com/?l=linux-kernel&m=107338033309435&w=2 It means that this compile oddity will be fixed at kernel side (2.6.1).
participants (3)
-
Alexandre Julliard -
Joerg Mayer -
P. Christeas