Re: [PATCH] gdi32: Add traces for painting functions

[Huw Davies]

On Sat, Jan 21, 2017 at 06:45:31PM +0100, Fabian Maurer wrote:
> Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de>
> ---
>  dlls/gdi32/painting.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 52 insertions(+), 4 deletions(-)

I would suggest printing the point-like terms in the same way as
wine_dbgstr_point() and the rect-like terms in the same way as
wine_dbgstr_rect().
> @@ -237,6 +237,8 @@ BOOL WINAPI LineTo( HDC hdc, INT x, INT y )
>      PHYSDEV physdev;
>      BOOL ret;
>
> +    TRACE( "%p, %d, %d\n", hdc, x, y );

So this would be:
  TRACE( "%p, (%d,%d)\n", hdc, x, y );
> @@ -288,6 +292,8 @@ BOOL WINAPI Arc( HDC hdc, INT left, INT top, INT right,
>      BOOL ret;
>      DC * dc = get_dc_ptr( hdc );
>
> +    TRACE( "%p, %d, %d, %d, %d,  %d, %d, %d, %d\n", hdc, left, top, right, bottom, xstart, ystart, xend, yend );

And this would be:
  TRACE( "%p, (%d,%d)-(%d,%d), (%d,%d), (%d,%d)\n", hdc, left, top, right, bottom, xstart, ystart, xend, yend );
> @@ -421,6 +437,8 @@ BOOL WINAPI RoundRect( HDC hdc, INT left, INT top, INT right,
>      BOOL ret;
>      DC *dc = get_dc_ptr( hdc );
>
> +    TRACE( "%p, %d, %d, %d, %d, %d, %d\n", hdc, left, top, right, bottom, ell_width, ell_height );

A size-like term could be:

 TRACE( "%p, (%d,%d)-(%d,%d), %dx%d\n", hdc, left, top, right, bottom, ell_width, ell_height );
> @@ -702,6 +738,8 @@ BOOL WINAPI ExtFloodFill( HDC hdc, INT x, INT y, COLORREF color,
>      BOOL ret;
>      DC * dc = get_dc_ptr( hdc );
>
> +    TRACE( "%p, %d, %d, %x, %x\n", hdc, x, y, color, fillType );

color should be %08x

Huw.

[PATCH] gdi32: Add traces for painting functions

[Fabian Maurer]

On Tuesday, January 24, 2017 9:02:34 AM CET Huw Davies wrote:
> I would suggest printing the point-like terms in the same way as
> wine_dbgstr_point() and the rect-like terms in the same way as
> wine_dbgstr_rect().

Thanks for the feedback, I sent an improved version.