Preparing Wine 5.0.1 for GCC 10
Hi Alexandre, can you please push the patches to the Wine 5.0 branch for the 5.0.1 release? That'll allow the stable release branch to build on rolling distros with newer compilers over the coming months/year. commit 1d785798605c01dcfc8a2f9f6ecc24bc21351029 Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Wed Apr 15 21:43:42 2020 +0800 schedsvc/tests: Fix compilation with recent gcc/clang versions. commit ea032bb7f8daddfe308f86f52c54db5f657b658a Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Tue Jan 28 22:40:25 2020 +0100 msi: Properly declare variables in msi/tests/utils.h as extern. Omitting the extern storage qualifier when declaring a global variable in a header file is mistake. If that header is included by several files it results in multiple definitions of the same variable (unless -fcommon is specified or assumed, the latter being the case for GCC 9.x and earlier). This fixes building with GCC 10. commit c13d58780f78393571dfdeb5b4952e3dcd7ded90 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:24 2020 -0600 sane.ds: Global variable compatibility update for gcc 10. commit 453980e13015e20dd551531be69b3361b63f22b1 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:21 2020 -0600 gphoto2.ds: Global variable compatibility update for gcc 10. commit bc51c5d589de709e1d393b58b0cc5985c78061ac Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:28 2020 -0600 webservices: Global variable compatibility update for gcc 10. commit cc7f698b8245a48669d248569e7589ff824f2c70 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:23 2020 -0600 msi: Global variable compatibility update for gcc 10. Thank you, Gerald
Hi, Stable branch is maintained by Michael: https://wiki.winehq.org/Stable_Rules . On Tue, Apr 28, 2020 at 6:48 AM Gerald Pfeifer <gerald(a)pfeifer.com> wrote:
Hi Alexandre,
can you please push the patches to the Wine 5.0 branch for the 5.0.1 release?
That'll allow the stable release branch to build on rolling distros with newer compilers over the coming months/year.
commit 1d785798605c01dcfc8a2f9f6ecc24bc21351029 Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Wed Apr 15 21:43:42 2020 +0800
schedsvc/tests: Fix compilation with recent gcc/clang versions.
commit ea032bb7f8daddfe308f86f52c54db5f657b658a Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Tue Jan 28 22:40:25 2020 +0100
msi: Properly declare variables in msi/tests/utils.h as extern.
Omitting the extern storage qualifier when declaring a global variable in a header file is mistake. If that header is included by several files it results in multiple definitions of the same variable (unless -fcommon is specified or assumed, the latter being the case for GCC 9.x and earlier).
This fixes building with GCC 10.
commit c13d58780f78393571dfdeb5b4952e3dcd7ded90 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:24 2020 -0600
sane.ds: Global variable compatibility update for gcc 10.
commit 453980e13015e20dd551531be69b3361b63f22b1 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:21 2020 -0600
gphoto2.ds: Global variable compatibility update for gcc 10.
commit bc51c5d589de709e1d393b58b0cc5985c78061ac Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:28 2020 -0600
webservices: Global variable compatibility update for gcc 10.
commit cc7f698b8245a48669d248569e7589ff824f2c70 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:23 2020 -0600
msi: Global variable compatibility update for gcc 10.
Thank you, Gerald
-- Regards, Jactry Zeng
Thanks for the patch list Gerald. I need to upgrade to Fedora 32 so I'll be on gcc 10 anyway during 5.0.x bye michael On 4/27/20 1:19 PM, Gerald Pfeifer wrote:
can you please push the patches to the Wine 5.0 branch for the 5.0.1 release?
That'll allow the stable release branch to build on rolling distros with newer compilers over the coming months/year.
commit 1d785798605c01dcfc8a2f9f6ecc24bc21351029 Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Wed Apr 15 21:43:42 2020 +0800
schedsvc/tests: Fix compilation with recent gcc/clang versions.
commit ea032bb7f8daddfe308f86f52c54db5f657b658a Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Tue Jan 28 22:40:25 2020 +0100
msi: Properly declare variables in msi/tests/utils.h as extern.
Omitting the extern storage qualifier when declaring a global variable in a header file is mistake. If that header is included by several files it results in multiple definitions of the same variable (unless -fcommon is specified or assumed, the latter being the case for GCC 9.x and earlier).
This fixes building with GCC 10.
commit c13d58780f78393571dfdeb5b4952e3dcd7ded90 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:24 2020 -0600
sane.ds: Global variable compatibility update for gcc 10.
commit 453980e13015e20dd551531be69b3361b63f22b1 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:21 2020 -0600
gphoto2.ds: Global variable compatibility update for gcc 10.
commit bc51c5d589de709e1d393b58b0cc5985c78061ac Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:28 2020 -0600
webservices: Global variable compatibility update for gcc 10.
commit cc7f698b8245a48669d248569e7589ff824f2c70 Author: Michael Cronenworth <mike(a)cchtml.com> Date: Thu Jan 23 17:05:23 2020 -0600
msi: Global variable compatibility update for gcc 10.
Thank you, Gerald
On Tue, 28 Apr 2020, Jactry Zeng wrote:
Stable branch is maintained by Michael: https://wiki.winehq.org/Stable_Rules
Thank you, Jactry, for that helpful pointer! I had a look, and https://wiki.winehq.org/Special:WhatLinksHere/Stable_Rules indicates no other page is linking to that one (short of a redirect)? On Tue, 28 Apr 2020, Michael Stefaniuc wrote:
Thanks for the patch list Gerald. I need to upgrade to Fedora 32 so I'll be on gcc 10 anyway during 5.0.x
Great, thank you, Michael! Do you already have a date for 5.0.1 in mind? Gerald
On 4/28/20 11:48 PM, Gerald Pfeifer wrote:
On Tue, 28 Apr 2020, Jactry Zeng wrote:
Stable branch is maintained by Michael: https://wiki.winehq.org/Stable_Rules
Thank you, Jactry, for that helpful pointer!
I had a look, and https://wiki.winehq.org/Special:WhatLinksHere/Stable_Rules indicates no other page is linking to that one (short of a redirect)? I'm linking from outside to it: https://people.redhat.com/mstefani/wine/stable/ https://github.com/mstefani/wine-stable
Those are the links I'm including in my Stable rc emails. Where did you look for it on the wiki? Just as a hint where it might make sense to add it. In theory it should go to the Developer section. But new developers don't come to Wine for Stable. And longer term developers see my emails on wine-devel so wouldn't go to the Developer section for that information.
On Tue, 28 Apr 2020, Michael Stefaniuc wrote:
Thanks for the patch list Gerald. I need to upgrade to Fedora 32 so I'll be on gcc 10 anyway during 5.0.x
Great, thank you, Michael!
Do you already have a date for 5.0.1 in mind? If all goes well: mid May.
bye michael
On Wed, 29 Apr 2020 21:18:18 +0200 Michael Stefaniuc <mstefani(a)winehq.org> wrote:
Where did you look for it on the wiki? Just as a hint where it might make sense to add it. In theory it should go to the Developer section. But new developers don't come to Wine for Stable. And longer term developers see my emails on wine-devel so wouldn't go to the Developer section for that information.
Maybe a "see also" link at the bottom of the Submitting Patches page? -- Rosanne DiMesio dimesio(a)earthlink.net
participants (4)
-
Gerald Pfeifer -
Jactry Zeng -
Michael Stefaniuc -
Rosanne DiMesio