Re: [PATCH 1/4] user32: Don't forward EnableWindow to the window's thread.
On 05.03.2017 20:21, Zebediah Figura wrote:
Fixes https://bugs.winehq.org/show_bug.cgi?id=42568
The only apparent use of this is to kill the focus and capture of the window if the thread doesn't own it. However, testing reveals that on Windows the focus isn't killed either, and the capture is handled by DefWindowProc, as already implemented in Wine.
Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/user32/message.c | 3 --- dlls/user32/spy.c | 1 - dlls/user32/tests/msg.c | 8 +++----- dlls/user32/user_private.h | 1 - dlls/user32/win.c | 12 ------------ 5 files changed, 3 insertions(+), 22 deletions(-)
You will at least have to forward for other processes (see for example the WIN_SetStyle implementation). Best regards, Sebastian
On 03/05/2017 01:37 PM, Sebastian Lackner wrote:
On 05.03.2017 20:21, Zebediah Figura wrote:
Fixes https://bugs.winehq.org/show_bug.cgi?id=42568
The only apparent use of this is to kill the focus and capture of the window if the thread doesn't own it. However, testing reveals that on Windows the focus isn't killed either, and the capture is handled by DefWindowProc, as already implemented in Wine.
Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/user32/message.c | 3 --- dlls/user32/spy.c | 1 - dlls/user32/tests/msg.c | 8 +++----- dlls/user32/user_private.h | 1 - dlls/user32/win.c | 12 ------------ 5 files changed, 3 insertions(+), 22 deletions(-)
You will at least have to forward for other processes (see for example the WIN_SetStyle implementation).
Best regards, Sebastian
Thanks. Focus and capture appear to work in the same way, but WIN_SetStyle can't set the style from an outside process, and so it spits an error and fails. I'll try to fix that function and resend the patch.
participants (2)
-
Sebastian Lackner -
Zebediah Figura