Re: [PATCH 2/6] gdiplus: Support GdipSetPixelOffsetMode in metafiles

[Dmitry Timoshkov]

Piotr Caban <piotr(a)codeweavers.com> wrote:
> +    if(graphics->pixeloffset == mode)
> +        return Ok;

This particular change would need an approproate test case to confirm
that repetitive GdipSetPixelOffsetMode() calls with the same value won't
generate new records.

Same applies to other patches in the series.

-- 
Dmitry.

[PATCH 2/6] gdiplus: Support GdipSetPixelOffsetMode in metafiles

[Dmitry Timoshkov]

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> Piotr Caban <piotr(a)codeweavers.com> wrote:
> > +    if(graphics->pixeloffset == mode)
> > +        return Ok;
>
> This particular change would need an approproate test case to confirm
> that repetitive GdipSetPixelOffsetMode() calls with the same value won't
> generate new records.
>
> Same applies to other patches in the series.

I see that you've added the tests in 7/7, the patches look good to me.

-- 
Dmitry.