Re: [Tools 5/6] winetest: Add statistics for the number of unit tests with errors or todos.

[Paul Vriens]

Francois Gouget wrote:
> Also tweak the headers and footers a bit.
> ---
>
> This gives us a better idea of how many unit tests are failing.
>
> winetest/gather |   67 ++++++++++++++++++++++++++++++++++++++++++++++++++----
>  1 files changed, 62 insertions(+), 5 deletions(-)
>
> diff --git a/winetest/gather b/winetest/gather

Hi Francois,

I think something is 'wrong' with the statistics for the Wine group:

http://test.winehq.org/data/200803211000/#group_Wine

They are the same for every box with respect to the "X + Y". The title (on mouse 
  over) is correct though.

-- 
Cheers,

Paul.

[Tools 5/6] winetest: Add statistics for the number of unit tests with errors or todos.

[Paul Vriens]

Paul Vriens wrote:
> Francois Gouget wrote:
> > Also tweak the headers and footers a bit.
> > ---
> >
> > This gives us a better idea of how many unit tests are failing.
> >
> > winetest/gather |   67 
> > ++++++++++++++++++++++++++++++++++++++++++++++++++----
> >  1 files changed, 62 insertions(+), 5 deletions(-)
> >
> > diff --git a/winetest/gather b/winetest/gather
>
> Hi Francois,
>
> I think something is 'wrong' with the statistics for the Wine group:
>
> http://test.winehq.org/data/200803211000/#group_Wine
>
> They are the same for every box with respect to the "X + Y". The title 
> (on mouse  over) is correct though.

Would this do? :

diff --git a/winetest/gather b/winetest/gather
index 294ad06..fdacff5 100755
--- a/winetest/gather
+++ b/winetest/gather
@@ -362,7 +362,7 @@ EOF
                      "pass";
          my $count=!$report->{todos} ? $report->{errors} :
                    !$report->{errors} ? $report->{todos} :
-                  "$group->{errors}+$group->{todos}";
+                  "$report->{errors}+$report->{todos}";

          my $prcnt=!$report->{todos} ? percent($report->{errors}, $unit_count) :
                    !$report->{errors} ? percent($report->{todos}, $unit_count) :


-- 
Cheers,

Paul.

[Tools 5/6] winetest: Add statistics for the number of unit tests with errors or todos.

[Francois Gouget]

[...]
> Would this do? :
>
> diff --git a/winetest/gather b/winetest/gather
> index 294ad06..fdacff5 100755
> --- a/winetest/gather
> +++ b/winetest/gather
> @@ -362,7 +362,7 @@ EOF
>                      "pass";
>          my $count=!$report->{todos} ? $report->{errors} :
>                    !$report->{errors} ? $report->{todos} :
> -                  "$group->{errors}+$group->{todos}";
> +                  "$report->{errors}+$report->{todos}";
>
> my $prcnt=!$report->{todos} ? percent($report->{errors}, $unit_count)
> :
>                    !$report->{errors} ? percent($report->{todos}, $unit_count)
> :

Yes, this patch is correct. Please, submit it to wine-patches.


-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
           Cahn's Axiom: When all else fails, read the instructions.