Re: [3/5] wined3d: Make the offscreen render mode a registry setting

[Ivan Gyurdiev]

This flag needs to be per adapter - should be added to device.c like the 
shader mode.

[3/5] wined3d: Make the offscreen render mode a registry setting

[H. Verbeet]

On 17/11/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote:
> This flag needs to be per adapter - should be added to device.c like the
> shader mode.

Well, the registry setting is global. I'm not sure if it really makes
sense to use different offscreen rendering modes for different
devices.

[3/5] wined3d: Make the offscreen render mode a registry setting

[Ivan Gyurdiev]

H. Verbeet wrote:
> On 17/11/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote:
> > This flag needs to be per adapter - should be added to device.c like the
> > shader mode.
>
> Well, the registry setting is global. I'm not sure if it really makes
> sense to use different offscreen rendering modes for different
> devices.
> Sure it does - different cards have different capabilities [ but like I 
> mentioned in the other mail, I think you're missing the "support" bit of 
> "configuration + support" that should be used to choose offscreen mode ].

[3/5] wined3d: Make the offscreen render mode a registry setting

[H. Verbeet]

On 17/11/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote:
> H. Verbeet wrote:
> > On 17/11/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote:
> > > This flag needs to be per adapter - should be added to device.c like the
> > > shader mode.
> >
> > Well, the registry setting is global. I'm not sure if it really makes
> > sense to use different offscreen rendering modes for different
> > devices.
> > Sure it does - different cards have different capabilities [ but like I
> > mentioned in the other mail, I think you're missing the "support" bit of
> > "configuration + support" that should be used to choose offscreen mode ].
> > I think you're missing the point of the setting. It's something
> > internal for developers.

[3/5] wined3d: Make the offscreen render mode a registry setting

[Ivan Gyurdiev]

H. Verbeet wrote:
> On 17/11/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote:
> > H. Verbeet wrote:
> > > On 17/11/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote:
> > > > This flag needs to be per adapter - should be added to device.c 
> > > > like the
> > > > shader mode.
> > >
> > > Well, the registry setting is global. I'm not sure if it really makes
> > > sense to use different offscreen rendering modes for different
> > > devices.
> > > Sure it does - different cards have different capabilities [ but like I
> > > mentioned in the other mail, I think you're missing the "support" bit of
> > > "configuration + support" that should be used to choose offscreen 
> > > mode ].
> > > I think you're missing the point of the setting. It's something
> > > internal for developers.
> > > No, you're adding code all over the place that looks up this setting - 
> > > this will have to be changed later. It's the exact same thing I did with 
> > > shader mode, so just trying to shortcut to the end result...

[3/5] wined3d: Make the offscreen render mode a registry setting

[H. Verbeet]

On 17/11/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote:
> No, you're adding code all over the place that looks up this setting -
> this will have to be changed later. It's the exact same thing I did with
> shader mode, so just trying to shortcut to the end result...

My plan is to remove the checks for both this and the shader code
completely, and switch to a more driver like structure, where we
simply load the correct backend at initialisation, and call stuff
through there.

[3/5] wined3d: Make the offscreen render mode a registry setting

[Ivan Gyurdiev]

Ivan Gyurdiev wrote:
> This flag needs to be per adapter - should be added to device.c like 
> the shader mode.
> I meant the device structure.

Also, the mode selection should include configuration and support 
detection - I think you're missing the support detection. Imho there 
should be a select_offscreen_mode() function like the shader mode is 
done, selecting between fbo, pbuffer, and none.

[3/5] wined3d: Make the offscreen render mode a registry setting

[H. Verbeet]

On 17/11/06, Ivan Gyurdiev <ivg231(a)gmail.com> wrote:
> Ivan Gyurdiev wrote:
> > This flag needs to be per adapter - should be added to device.c like
> > the shader mode.
> > I meant the device structure.
> > Yeah, I got that.
> Also, the mode selection should include configuration and support
> detection - I think you're missing the support detection. Imho there
> should be a select_offscreen_mode() function like the shader mode is
> done, selecting between fbo, pbuffer, and none.
> Well, it's an internal registry setting for developers, I don't think
> it's needed at this point.