Re: [PATCH] dmusic: Variable spelling fix.

[Andrew Eikum]

On Thu, May 10, 2012 at 07:52:58AM +0200, Christian Costa wrote:
> static HRESULT read_from_stream(IStream *stream, void *data, ULONG size)
>  {
> -    ULONG readed;
> +    ULONG read;
>      HRESULT hr;
>
> -    hr = IStream_Read(stream, data, size, &readed);
> +    hr = IStream_Read(stream, data, size, &read);
>      if(FAILED(hr)){

I called it that to prevent shadowing read(3). It probably doesn't
matter since we almost never use that call in Wine, but that was the
rationale.

Andrew

[PATCH] dmusic: Variable spelling fix.

[Christian Costa]

2012/5/10 Andrew Eikum <aeikum(a)codeweavers.com>
> On Thu, May 10, 2012 at 07:52:58AM +0200, Christian Costa wrote:
> > static HRESULT read_from_stream(IStream *stream, void *data, ULONG size)
> >  {
> > -    ULONG readed;
> > +    ULONG read;
> >      HRESULT hr;
> >
> > -    hr = IStream_Read(stream, data, size, &readed);
> > +    hr = IStream_Read(stream, data, size, &read);
> >      if(FAILED(hr)){
>
> I called it that to prevent shadowing read(3). It probably doesn't
> matter since we almost never use that call in Wine, but that was the
> rationale.

Ok. Something like bytes_read would be even better then. :)

Christian